JAMES-1862 Generalize STARTTLS sanitizing fix #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibenwa
force-pushed
the
JAMES-1862-generic
branch
from
a44687a
to
ea222c7
Compare
chibenwa
force-pushed
the
JAMES-1862-generic
branch
from
a496138
to
091a7f3
Compare
Arsnael
approved these changes
Aug 16, 2021
All line based protocols are subject to command injections for "man in the middle" attacks. We hereby generalize the SMTP fix. Note that we slightly modified the behaviour to bypass this sanitizing as soon as the users are authenticated: indeed authentication happens for sure after STARTTLS upgrades.
chibenwa
force-pushed
the
JAMES-1862-generic
branch
from
091a7f3
to
9da8bc7
Compare
|
Force pushed to solve conflict... |
Looks related. I will have a look. |
https://www.usenix.org/system/files/sec21-poddebniak.pdf Session 6.2 James allows session fixation as part of the SMTP protocol but as stated by the researchers, 'they did not come up with exploits'.
chibenwa
force-pushed
the
JAMES-1862-generic
branch
from
9da8bc7
to
cbb114f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All line based protocols are subject to command injections for "man in the middle"
attacks. We hereby generalize the SMTP fix.
Note that we slightly modified the behaviour to bypass this sanitizing as soon as the users
are authenticated: indeed authentication happens for sure after STARTTLS upgrades.
TODO: