JAMES-3737 Ability to execute IMAP workload directly on the event loop #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibenwa
force-pushed
the
JAMES-3737-eventloop
branch
from
5bc3bfc
to
7fdc36e
Compare
Arsnael
approved these changes
Apr 22, 2022
Arsnael
approved these changes
Apr 25, 2022
quantranhong1999
approved these changes
Apr 26, 2022
chibenwa
force-pushed
the
JAMES-3737-eventloop
branch
2 times, most recently
from
653ccf2
to
f605986
Compare
…ents - Reduce counts of parameters -Also avoid a double map lookup
This enable executing all IMAP requests on the event loop
Avoids context switches on each IMAP requests
They run on an eventLoop thus are immediately applied
Compress response and activation was sent from the event loop causing them to be sent and activated prior earlier responses. This causes a race condition when several commands are batched.
STARTTLS response and activation was sent from the event loop causing them to be sent and activated prior earlier responses. This causes a race condition when several commands are batched.
chibenwa
force-pushed
the
JAMES-3737-eventloop
branch
from
f605986
to
acd0f93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we now have reactive IMAP command execution (non blocking)
If we succeed to do large appends command parsing (buffered to a file thus blocking) asynchronously
Then we could handle the all IMAP workload without context switches.
Experimentally we were able to sensibly