New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JCLOUDS-1618: Upgrade to gson 2.10.1 #176
Conversation
CI reports:
I don't know if Java 17 is an intended requirement but I am flagging this. |
project/pom.xml
Outdated
@@ -217,12 +227,12 @@ | |||
<project.build.outputTimestamp>1668154596</project.build.outputTimestamp> | |||
|
|||
<!-- Plugin versions --> | |||
<bnd.version>5.2.0</bnd.version> | |||
<bnd.version>7.0.0-SNAPSHOT</bnd.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why we are using bnd in the first place -- is this some kind of OSGi thing? @jbonofre
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively we could remove all uses of bnd and <manifestFile>
from maven-jar-plugin.
This blocks upgrading gson. References apache#176.
This blocks upgrading gson. References apache#176.
This blocks upgrading gson. References #176.
Looking at the error and comparing the bnd-plugin metadata I found that the version in use 5.2 can be updated until 6.0.0.
|
No reversion, see #177 (comment). |
Hi, Any plan to have this released ? Outdated gson cause now some issues on a Jenkins plugin (artifact-manager-s3-plugin) (https://issues.jenkins.io/browse/JENKINS-72441, jenkinsci/gson-api-plugin#7)
Thanks! |
This also upgrades bnd to 7.0.0-SNAPSHOT to work around aMETA-INF/versions/9/module-info.class=module-info
issue. Obviously we cannot merge this due to the use of a SNAPSHOT version but maybe someone has a better suggestion how to approach this?Removed bnd in #177.