Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bnd #177

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Remove bnd #177

merged 1 commit into from
Jun 16, 2023

Conversation

gaul
Copy link
Member

@gaul gaul commented Jun 12, 2023

This blocks upgrading gson. References #176.

@gaul gaul requested a review from jbonofre June 12, 2023 06:07
@gaul
Copy link
Member Author

gaul commented Jun 12, 2023

@jbonofre I guess this is OSGi related but I lack the background to understand its use. Can we safely remove this without breaking OSGi support? If not, I think breaking OSGi to move forward with 2.6.0 is a good tradeoff.

This blocks upgrading gson.  References apache#176.
@gaul gaul changed the title Removed bnd Remove bnd Jun 12, 2023
@gaul gaul merged commit 2275637 into apache:master Jun 16, 2023
1 check passed
@gaul gaul deleted the deps/remove-bnd branch June 16, 2023 01:45
@gurkerl83
Copy link

gurkerl83 commented Jul 5, 2023

@gaul I have to say it but I guess this completely breaks OSGi compatibility. I introduced the bnd plugin here which really simplified the OSGi support 8ac994c . Please revert the commit and I will take a look.

Probably related
#176 (comment)

@gaul
Copy link
Member Author

gaul commented Jul 5, 2023

Sorry no reversions. We have been talking about this problem for almost a year so the burden is on the community to find a better solution. If you want to submit a fix that preserves gson 2.10.1 you can try to do this but I plan to cut the next (final) release in a few weeks so you should start now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants