Bug 62257 - Expand/Collapse short key doesn't work with numpad -

[orimarko]

Description

Fixed Bug 62257 - Expand/Collapse short key doesn't work with numpad -

Add new keystrokes for numpad - sign for expanding/collapsing JMeter tree

Motivation and Context

Fixing open issue since JMeter 4 version:
https://bz.apache.org/bugzilla/show_bug.cgi?id=62257

How Has This Been Tested?

Tested using ant run_gui
Tested on Windows 7
Only added functionality to code

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• [x ] My code follows the code style of this project.
• [x ] I have updated the documentation accordingly.

[codecov-io]

Codecov Report

Merging #401 into trunk will decrease coverage by <.01%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##              trunk     #401      +/-   ##
============================================
- Coverage     58.57%   58.56%   -0.01%     
  Complexity    10615    10615              
============================================
  Files          1193     1193              
  Lines         75956    75970      +14     
  Branches       7347     7351       +4     
============================================
+ Hits          44488    44494       +6     
- Misses        28957    28964       +7     
- Partials       2511     2512       +1

Impacted Files	Coverage Δ	Complexity Δ
...jmeter/protocol/http/sampler/TestHTTPSamplers.java	100% <ø> (ø)	20 <0> (ø)	⬇️
...org/apache/jmeter/gui/tree/JMeterTreeListener.java	0% <0%> (ø)	0 <0> (ø)	⬇️
.../core/org/apache/jmeter/gui/action/KeyStrokes.java	89.83% <100%> (+0.35%)	1 <0> (ø)	⬇️
...c/core/org/apache/jmeter/reporters/Summariser.java	85.49% <0%> (-0.77%)	18% <0%> (-1%)
src/core/org/apache/jmeter/gui/action/Start.java	0% <0%> (ø)	0% <0%> (ø)	⬇️
src/core/org/apache/jmeter/engine/TreeCloner.java	100% <0%> (ø)	11% <0%> (ø)	⬇️
src/core/org/apache/jmeter/JMeter.java	38.39% <0%> (+0.18%)	45% <0%> (+1%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86d466b...5155599. Read the comment docs.

[FSchumacher]

Thanks for your contribution and for the correction of your name ;)

Have you tried shift+left cursor and shift+right cursor? They work fine on my install. Why would we want to have more than one keyboard short cut for the same functionality?

[orimarko]

Hello I'm fixing an issue of - sign. From https://wiki.apache.org/jmeter/JMeterShortcuts : * Collapse All : CTRL+"-" (not working on Mac) * Expand All : CTRL+SHIFT+"-" (not working on Mac) "-" sign can be found twice in the keyboard. The numpad sign wasn't working in windows, so I add it to Collapse/Expand All actions בתאריך שבת, 13 באוק׳ 2018, 17:59, מאת Felix Schumacher ‏< notifications@github.com>:

Thanks for your contribution and for the correction of your name ;) Have you tried shift+left cursor and shift+right cursor? They work fine on my install. Why would we want to have more than one keyboard short cut for the same functionality? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#401 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQV-YTpmLZgJEGZxe66BwFZX4sNi6gHkks5ukf_hgaJpZM4XHusr> .

בתאריך 13 באוק׳ 2018 5:59 PM,‏ "Felix Schumacher" <notifications@github.com> כתב: Thanks for your contribution and for the correction of your name ;) Have you tried shift+left cursor and shift+right cursor? They work fine on my install. Why would we want to have more than one keyboard short cut for the same functionality? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#401 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQV-YTpmLZgJEGZxe66BwFZX4sNi6gHkks5ukf_hgaJpZM4XHusr> .

[FSchumacher]

Do you think, we should support both key combinations, or should we rather fix the documentation to use the working combinations?

[orimarko]

As I see it, both key combinations are the same key in different location in keyboard
Therefore there's no need to change documentation