Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 62257 - Expand/Collapse short key doesn't work with numpad - #401

Closed
wants to merge 12 commits into from
Closed

Bug 62257 - Expand/Collapse short key doesn't work with numpad - #401

wants to merge 12 commits into from

Conversation

@orimarko
Copy link
Contributor

@orimarko orimarko commented Oct 4, 2018

Description

Fixed Bug 62257 - Expand/Collapse short key doesn't work with numpad -

Add new keystrokes for numpad - sign for expanding/collapsing JMeter tree

Motivation and Context

Fixing open issue since JMeter 4 version:
https://bz.apache.org/bugzilla/show_bug.cgi?id=62257

How Has This Been Tested?

Tested using ant run_gui
Tested on Windows 7
Only added functionality to code

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [x ] My code follows the code style of this project.
  • [x ] I have updated the documentation accordingly.
@codecov-io
Copy link

@codecov-io codecov-io commented Oct 11, 2018

Codecov Report

Merging #401 into trunk will decrease coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##              trunk     #401      +/-   ##
============================================
- Coverage     58.57%   58.56%   -0.01%     
  Complexity    10615    10615              
============================================
  Files          1193     1193              
  Lines         75956    75970      +14     
  Branches       7347     7351       +4     
============================================
+ Hits          44488    44494       +6     
- Misses        28957    28964       +7     
- Partials       2511     2512       +1
Impacted Files Coverage Δ Complexity Δ
...jmeter/protocol/http/sampler/TestHTTPSamplers.java 100% <ø> (ø) 20 <0> (ø) ⬇️
...org/apache/jmeter/gui/tree/JMeterTreeListener.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../core/org/apache/jmeter/gui/action/KeyStrokes.java 89.83% <100%> (+0.35%) 1 <0> (ø) ⬇️
...c/core/org/apache/jmeter/reporters/Summariser.java 85.49% <0%> (-0.77%) 18% <0%> (-1%)
src/core/org/apache/jmeter/gui/action/Start.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
src/core/org/apache/jmeter/engine/TreeCloner.java 100% <0%> (ø) 11% <0%> (ø) ⬇️
src/core/org/apache/jmeter/JMeter.java 38.39% <0%> (+0.18%) 45% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86d466b...5155599. Read the comment docs.

@FSchumacher
Copy link
Contributor

@FSchumacher FSchumacher commented Oct 13, 2018

Thanks for your contribution and for the correction of your name ;)

Have you tried shift+left cursor and shift+right cursor? They work fine on my install. Why would we want to have more than one keyboard short cut for the same functionality?

asfgit pushed a commit that referenced this issue Oct 13, 2018
@orimarko
Copy link
Contributor Author

@orimarko orimarko commented Oct 13, 2018

@FSchumacher
Copy link
Contributor

@FSchumacher FSchumacher commented Oct 28, 2018

Do you think, we should support both key combinations, or should we rather fix the documentation to use the working combinations?

@orimarko
Copy link
Contributor Author

@orimarko orimarko commented Oct 29, 2018

As I see it, both key combinations are the same key in different location in keyboard
Therefore there's no need to change documentation

@asfgit asfgit closed this in f9b5a71 Nov 1, 2018
Liard-Thomas added a commit to Liard-Thomas/jmeter that referenced this issue Nov 12, 2018
test formatage

xsd fait

Remplacement de XStream par SAX

freemarker fonctionnel dans un cas

Fonctionnel mais moche et pas encore testé

Bouton cancel et croix gérés correctement

Commentaires

factorisation de code

moins moche

Passage de popup à wizard

Fonctionnel

Sorted templates in alphabetical order

Correction Bug

Tests unitaires

imports inutiles

Suppression template de test

WIP

Expand/Collapse short key - (minus sign) on numpad doesn't work.

Contributed by Ori Marko (orimarko at gmail.com)

Closes apache#401 on github
Bugzilla Id: 62257

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1845516 13f79535-47bb-0310-9956-ffa450edef68

Bug 62847 - If Controller cannot use variable for index exposed by LoopController/WhileController/ForEachController
Bugzilla Id: 62847

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1845696 13f79535-47bb-0310-9956-ffa450edef68

Bug 62752 - Add to Documentation: ctx.getThreadNum() 0-based and ${__threadNum} 1-based
Bugzilla Id: 62752

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1845700 13f79535-47bb-0310-9956-ffa450edef68

Add location of JMeterContext API to link and write out numbers as words

Follow-up to r1845700
Bug 62752 - Add to Documentation: ctx.getThreadNum() 0-based and
${__threadNum} 1-based

Bugzilla Id: 62752

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1845725 13f79535-47bb-0310-9956-ffa450edef68

Rephrase sentence about the uniqueness of the threadNums.

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1845726 13f79535-47bb-0310-9956-ffa450edef68

English typography suggests there is no space before a colon

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1845727 13f79535-47bb-0310-9956-ffa450edef68

Markup changes. Use code macro

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1845728 13f79535-47bb-0310-9956-ffa450edef68

Spacepolice. Remove whitespace at the end of lines

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1845729 13f79535-47bb-0310-9956-ffa450edef68

Bug 62883 - Report / Dashboard : Change the way percentiles are computed for Response Time Percentiles Over Time (successful responses) graph
Bugzilla Id: 62883

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1845737 13f79535-47bb-0310-9956-ffa450edef68

Fix typo as per Felix comment

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1845740 13f79535-47bb-0310-9956-ffa450edef68

Bug 62806 ModuleController cloning by Run behaves differently wether in GUI or Non GUI mode.
Reinstate old method signature to avoid NoSuchMethodError in calling plugins and deprecate it
Bugzilla Id: 62806

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1845917 13f79535-47bb-0310-9956-ffa450edef68

Cleanup some SONAR warnings
Remove old TODO

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1845970 13f79535-47bb-0310-9956-ffa450edef68

Try to improve javadoc

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1845971 13f79535-47bb-0310-9956-ffa450edef68

SHA1 is alias for SHA-1, but SHA-1 would work in most scenario

Contributed by pacoxu
This closes apache#411

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1845973 13f79535-47bb-0310-9956-ffa450edef68

Change Test Action (old name) to "Flow Control Action" in Component Reference

Contributed by Ori Marko
This closes apache#428

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1845975 13f79535-47bb-0310-9956-ffa450edef68

Format JSON Arrays when displayed with JSON Path Tester

Bugzilla Id: 62889

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1846060 13f79535-47bb-0310-9956-ffa450edef68

Make checkstyle happy and shorten line of length.

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1846061 13f79535-47bb-0310-9956-ffa450edef68

Use format string in log message.

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1846197 13f79535-47bb-0310-9956-ffa450edef68

Bug 62894 : Report / Dashboard : Throughput is in wrong column which is confusing as unit is milliseconds
Bugzilla Id: 62894

git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1846204 13f79535-47bb-0310-9956-ffa450edef68

Synch with trunk

testTemplates ok

Restauration ancienne version messages.properties

templates.xml update

clean for pr

formattage

formattage

finit

customs templates
hitesh22 pushed a commit to hitesh22/jmeter that referenced this issue Nov 15, 2018
Contributed by Ori Marko (orimarko at gmail.com)

Closes apache#401 on github
Bugzilla Id: 62257


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1845516 13f79535-47bb-0310-9956-ffa450edef68
StorDm pushed a commit to etnetera/jmeter that referenced this issue Jan 7, 2021
StorDm pushed a commit to etnetera/jmeter that referenced this issue Jan 7, 2021
Contributed by Ori Marko (orimarko at gmail.com)

Closes apache#401 on github
Bugzilla Id: 62257


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1845516 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: f9b5a71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants