Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native properties #437

Closed
wants to merge 2 commits into from
Closed

Native properties #437

wants to merge 2 commits into from

Conversation

@FSchumacher
Copy link
Contributor

@FSchumacher FSchumacher commented Jan 11, 2019

Description

Use native encoding for properties files in the source directories

Motivation and Context

Currently the properties files are encoded using the native2ascii program as properties file read by java have to be in ASCII. Those encoded files are hard to read and error prone. By converting them to UTF-8 it should be easier to maintain.
The properties files will be encoded when the corresponding sources are compiled.

How Has This Been Tested?

Checked the generated properties file by hand and run JMeter in GUI mode.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
FSchumacher added 2 commits Jan 11, 2019
Used the tool native2ascii to convert the ascii encoded properties
to utf-8. It should now be easier for language translators to edit those
files.

$ find src/ -name "*.properties"  | while read i
  do
    native2ascii -reverse $i $i.new && mv $i.new $i
  done
@pmouawad
Copy link
Contributor

@pmouawad pmouawad commented Jan 15, 2019

+1, Thanks

asfgit pushed a commit that referenced this issue Jan 17, 2019
Part of #437 on github.

Bugzilla Id: 63082


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1851506 13f79535-47bb-0310-9956-ffa450edef68
asfgit pushed a commit that referenced this issue Jan 17, 2019
Used the tool native2ascii to convert the ascii encoded properties
to utf-8. It should now be easier for language translators to edit those
files.

$ find src/ -name "*.properties"  | while read i
  do
    native2ascii -reverse $i $i.new && mv $i.new $i
  done

Related to #437 on github
Bugzilla Id: 63082


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1851507 13f79535-47bb-0310-9956-ffa450edef68
@asfgit asfgit closed this in 760fb29 Jan 17, 2019
asfgit pushed a commit that referenced this issue Jan 17, 2019
Related to #437
Bugzilla Id: 63082


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1851509 13f79535-47bb-0310-9956-ffa450edef68
asfgit pushed a commit that referenced this issue Jan 21, 2019
As I don't speak portuguese, it would be great if someone else could look at
this commit :)

Closes #437 on github
Bugzilla Id: 63082



git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1851767 13f79535-47bb-0310-9956-ffa450edef68
StorDm pushed a commit to etnetera/jmeter that referenced this issue Jan 7, 2021
Part of apache#437 on github.

Bugzilla Id: 63082


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1851506 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: 5ca9c24
StorDm pushed a commit to etnetera/jmeter that referenced this issue Jan 7, 2021
Used the tool native2ascii to convert the ascii encoded properties
to utf-8. It should now be easier for language translators to edit those
files.

$ find src/ -name "*.properties"  | while read i
  do
    native2ascii -reverse $i $i.new && mv $i.new $i
  done

Related to apache#437 on github
Bugzilla Id: 63082


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1851507 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: c254c8c
StorDm pushed a commit to etnetera/jmeter that referenced this issue Jan 7, 2021
These double encoded characters were introduced a long time ago, but
nobody seems to have noticed them.

As I don't speak french, it would be great if someone else could look at
this commit :)

One brazilian properties file has still some wrong characters that can be
found by

$ grep '√' -r src/

Closes apache#437 on github
Bugzilla Id: 63082


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1851508 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: 760fb29
StorDm pushed a commit to etnetera/jmeter that referenced this issue Jan 7, 2021
Related to apache#437
Bugzilla Id: 63082


git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1851509 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: 2029a80
StorDm pushed a commit to etnetera/jmeter that referenced this issue Jan 7, 2021
As I don't speak portuguese, it would be great if someone else could look at
this commit :)

Closes apache#437 on github
Bugzilla Id: 63082



git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1851767 13f79535-47bb-0310-9956-ffa450edef68

Former-commit-id: c629e61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants