Facelift ThreadGroup UI, improve alignment of Name+Commments fields for all components #513

vlsi · 2019-10-02T21:08:55Z

Description

This is a draft, however, it enables us to preview how aligned fields might look like.

Note: I did not touch radio-buttons yet.

Screenshots (if appropriate):

Before:

After:

ham1 · 2019-10-02T23:28:47Z

Much nicer already :)

ThomasArdal · 2019-10-03T05:23:16Z

Looks awesome. I would have left-aligned Thread group, Name, and Comments with the borders below. And decreased the top margin to make more room for content. It might just be a personal opinion. Basically like on the Before shot.

vlsi · 2019-10-03T05:34:22Z

Just in case: the labels in the "scheduler configuration" section miss colons.

vlsi · 2019-10-03T06:34:32Z

And decreased the top margin to make more room for content

Indeed. I've removed the extra margin and I've updated "after" image.

pmouawad · 2019-10-04T11:29:55Z

Hi Felix,
If this has been tested on Windows , Linux and MacOSX and on HDMI screen, then you should commit it.
Or do you need to work on it ?

On what platforms did you test so that we test on others ?
How could we work together on this ?

vlsi · 2019-10-04T11:41:29Z

@pmouawad , I'm still updating the UI.

How could we work together on this ?

Do you intend to implement the related changes as well?

I suggest as follows: I'll finish with Tread Group, commit it, then we could revise other components. Ok?

pmouawad · 2019-10-04T11:45:29Z

On Friday, October 4, 2019, Vladimir Sitnikov ***@***.***> wrote: @pmouawad <https://github.com/pmouawad> , I'm still updating the UI. How could we work together on this ? Do you intend to implement the related changes as well?

Which ones ?

I suggest as follows: I'll finish with Tread Group, commit it, then we could revise other components. Ok?

ok by me

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#513?email_source=notifications&email_token=AAX3RK5JEIGG7R2KPR5SADDQM4TW3A5CNFSM4I43PIJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEALMGRQ#issuecomment-538362694>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAX3RK5HTVWKJQQK34BPIN3QM4TW3ANCNFSM4I43PIJQ> .

-- [image: logo Ubik Ingenierie] <https://www.ubik-ingenierie.com> Philippe Mouawad Senior Performance Expert 320914981 <+33320914981> | p.mouawad@ubik-ingenierie.com [image: ubik-ingenierie.com] ubik-ingenierie.com <https://www.ubik-ingenierie.com> | [image: 03.20.91.49.81] 03.20.91.49.81 <+33320914981> | [image: 23 rue du chemin de fer , 59100 , Roubaix] 23 rue du chemin de fer, 59100, Roubaix <https://www.openstreetmap.org/#map=18/50.69454/3.16455>

vlsi · 2019-10-04T13:13:58Z

@pmouawad , I've updated the PR, and it looks good to me now (provided Travis tests pass).
It would be great if someone could try the change. I've tested it with macOS.

@ThomasArdal , I wonder what would you think of the removal of "Scheduler Configuration" section.

codecov-io · 2019-10-04T13:26:57Z

Codecov Report

Merging #513 into master will decrease coverage by 0.01%.
The diff coverage is 95.45%.

@@             Coverage Diff              @@
##             master     #513      +/-   ##
============================================
- Coverage     56.16%   56.15%   -0.02%     
+ Complexity    10017    10016       -1     
============================================
  Files          1024     1024              
  Lines         62913    62897      -16     
  Branches       7064     7064              
============================================
- Hits          35337    35321      -16     
- Misses        25101    25104       +3     
+ Partials       2475     2472       -3

Impacted Files	Coverage Δ	Complexity Δ
.../main/java/org/apache/jmeter/gui/CommentPanel.java	`72.22% <ø> (-27.78%)`	`2 <0> (-3)`
...he/jmeter/visualizers/RespTimeGraphVisualizer.java	`50.95% <0%> (ø)`	`18 <0> (ø)`	⬇️
...apache/jmeter/visualizers/StatGraphVisualizer.java	`56.81% <0%> (ø)`	`25 <0> (ø)`	⬇️
...org/apache/jmeter/threads/AbstractThreadGroup.java	`84.78% <100%> (ø)`	`22 <1> (ø)`	⬇️
...src/main/java/org/apache/jmeter/gui/NamePanel.java	`86.48% <100%> (+0.37%)`	`13 <1> (+1)`	⬆️
...rg/apache/jmeter/control/gui/LoopControlPanel.java	`77.92% <100%> (+0.89%)`	`15 <3> (+3)`	⬆️
...che/jmeter/threads/gui/AbstractThreadGroupGui.java	`47.52% <100%> (ø)`	`9 <1> (ø)`	⬇️
.../org/apache/jmeter/threads/gui/ThreadGroupGui.java	`92.7% <100%> (-1.65%)`	`14 <3> (-3)`
.../main/java/org/apache/jmeter/util/JMeterUtils.java	`48.29% <100%> (+0.41%)`	`70 <1> (+1)`	⬆️
.../apache/jmeter/gui/AbstractJMeterGuiComponent.java	`92.64% <95.83%> (+5.34%)`	`18 <4> (-1)`	⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e2dda1...80b830e. Read the comment docs.

src/core/src/main/java/org/apache/jmeter/gui/AbstractJMeterGuiComponent.java

pmouawad · 2019-10-04T13:53:55Z

Hi @vlsi ,
I am not in favor of:

removing the warning even with renaming
switching to checkbox instead of radio button, I find it less clear. You have in mind that every tester knows that if it's unchecked it means "Different user for each iteration" which is not the case IME

ThomasArdal · 2019-10-04T14:08:38Z

I wonder what would you think of the removal of "Scheduler Configuration" section.

Not sure what that is? Or where it is?

vlsi · 2019-10-04T14:26:35Z

Not sure what that is? Or where it is?

I've updated the screenshots in the top comment. "Scheduler Configuration" was located at the bottom (it is visible in 'before' screenshot)

ThomasArdal · 2019-10-04T14:34:26Z

I don't think that I have ever used those fields.

ubikloadpack · 2019-10-04T14:37:49Z

I don't think that I have ever used those fields.

Did you use 3rd party Thread Group to configure duration of test ? or did you only use iterations ?
Or something else ?

When you look at new UI, does it look more clear in terms of what each property means ?

Thanks for your help

ubikloadpack · 2019-10-04T15:39:01Z

Should loop count be renamed to "Iterations" ?

vlsi · 2019-10-04T15:40:31Z

Should loop count be renamed to "Iterations" ?

It is reused from Loop Controller.
Do you suggest to rename the label there?
Do you suggest to use different labels for the same thing?

vlsi · 2019-10-04T15:40:58Z

What do you think of renaming Stop Test Now to Halt test?

ubikloadpack · 2019-10-04T15:42:49Z

Should loop count be renamed to "Iterations" ?

It is reused from Loop Controller.
Loop Controller is more of a "programatic element", I think user would understand
Do you suggest to rename the label there?
but if it's renamed it will be clear in both cases
Do you suggest to use different labels for the same thing?
As it's not good, iterations would be maybe more clear

ubikloadpack · 2019-10-04T15:43:42Z

Halt test

Force stop ?

…or all components

vlsi mentioned this pull request Oct 3, 2019

Is soft-wrap possible? mikaelgrev/miglayout#70

Closed

vlsi force-pushed the mig_threadgroup branch from 4b0ff0f to 75b52bb Compare October 4, 2019 12:41

vlsi changed the title ~~WIP: Align fields on Thread Group UI~~ Facelift ThreadGroup UI, improve alignment of Name+Commments fields for all components Oct 4, 2019

vlsi force-pushed the mig_threadgroup branch 4 times, most recently from 9b13ec7 to 8f24766 Compare October 4, 2019 13:13

ham1 reviewed Oct 4, 2019

View reviewed changes

src/core/src/main/java/org/apache/jmeter/gui/AbstractJMeterGuiComponent.java Show resolved Hide resolved

vlsi force-pushed the mig_threadgroup branch from 8f24766 to 5349c9f Compare October 4, 2019 15:36

vlsi force-pushed the mig_threadgroup branch 2 times, most recently from cef435a to a50c1bd Compare October 4, 2019 22:40

vlsi force-pushed the mig_threadgroup branch from b5c1199 to 9f3f9b3 Compare October 5, 2019 08:17

Facelift ThreadGroup UI, improve alignment of Name+Commments fields f…

80b830e

…or all components

vlsi force-pushed the mig_threadgroup branch from 9f3f9b3 to 80b830e Compare October 5, 2019 09:33

vlsi merged commit b0448c8 into apache:master Oct 5, 2019

vlsi mentioned this pull request Oct 5, 2019

Could "temporary default component constraints" be added? mikaelgrev/miglayout#71

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Facelift ThreadGroup UI, improve alignment of Name+Commments fields for all components #513

Facelift ThreadGroup UI, improve alignment of Name+Commments fields for all components #513

vlsi commented Oct 2, 2019 •

edited

Loading

ham1 commented Oct 2, 2019

ThomasArdal commented Oct 3, 2019 •

edited

Loading

vlsi commented Oct 3, 2019

vlsi commented Oct 3, 2019

pmouawad commented Oct 4, 2019

vlsi commented Oct 4, 2019

pmouawad commented Oct 4, 2019 via email

vlsi commented Oct 4, 2019

codecov-io commented Oct 4, 2019 •

edited

Loading

pmouawad commented Oct 4, 2019

ThomasArdal commented Oct 4, 2019

vlsi commented Oct 4, 2019 via email

ThomasArdal commented Oct 4, 2019

ubikloadpack commented Oct 4, 2019

ubikloadpack commented Oct 4, 2019

vlsi commented Oct 4, 2019

vlsi commented Oct 4, 2019

ubikloadpack commented Oct 4, 2019

ubikloadpack commented Oct 4, 2019

Facelift ThreadGroup UI, improve alignment of Name+Commments fields for all components #513

Facelift ThreadGroup UI, improve alignment of Name+Commments fields for all components #513

Conversation

vlsi commented Oct 2, 2019 • edited Loading

Description

Screenshots (if appropriate):

ham1 commented Oct 2, 2019

ThomasArdal commented Oct 3, 2019 • edited Loading

vlsi commented Oct 3, 2019

vlsi commented Oct 3, 2019

pmouawad commented Oct 4, 2019

vlsi commented Oct 4, 2019

pmouawad commented Oct 4, 2019 via email

vlsi commented Oct 4, 2019

codecov-io commented Oct 4, 2019 • edited Loading

Codecov Report

pmouawad commented Oct 4, 2019

ThomasArdal commented Oct 4, 2019

vlsi commented Oct 4, 2019 via email

ThomasArdal commented Oct 4, 2019

ubikloadpack commented Oct 4, 2019

ubikloadpack commented Oct 4, 2019

vlsi commented Oct 4, 2019

vlsi commented Oct 4, 2019

ubikloadpack commented Oct 4, 2019

ubikloadpack commented Oct 4, 2019

vlsi commented Oct 2, 2019 •

edited

Loading

ThomasArdal commented Oct 3, 2019 •

edited

Loading

codecov-io commented Oct 4, 2019 •

edited

Loading