chore: use Gradle toolchains for JDK provisioning #5989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlsi
force-pushed
the
toolchain
branch
4 times, most recently
from
8e5122d
to
3e90051
Compare
|
It looks like we might need several JVMs:
It would enable trying Java 21 even though it does not support building with Since Java 8, and even Java 11 are not updated that often, I would suggest we use Java 17 for build purposes, and then we vary "test JDKs". |
vlsi
force-pushed
the
toolchain
branch
7 times, most recently
from
3ede881
to
afc2dcd
Compare
It enables automatic JDK provisioning (e.g. download), and it enables using different JDKs for executing Gradle and for building JMeter Java version can be specified when building with -PjdkVersion=11 You could use ./gradlew -q javaToolchains to list the detected toolchains. See https://docs.gradle.org/8.0/userguide/toolchains.html#sec:consuming Fixes apache#5986
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It enables automatic JDK provisioning (e.g. download), and it enables using different JDKs for executing Gradle and for building JMeter.
The target bytecode is still 1.8 (it would be nice to bump the minimum requirements to Java 11), however, the build would require JDK 17 (it would automatically download one if none is detected locally)
Java version can be specified when building with
-PjdkVersion=11You could use
./gradlew -q javaToolchainsto list the detected toolchains.See https://docs.gradle.org/8.0/userguide/toolchains.html#sec:consuming
Fixes #5986