Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all buttons added to the toolbar behave/look consistently. #599

Merged
merged 1 commit into from Jun 24, 2020

Conversation

weisJ
Copy link
Contributor

@weisJ weisJ commented Jun 22, 2020

Description

Ensure all buttons added to the toolbar behave and look consistently.

Motivation and Context

Some plugins add own buttons to the toolbar e.g. JMeter Plugin.
Because those most likely aren't configured the same way the other buttons are they look/feel out of place.
This PR ensures that buttons in the toolbar are

  1. Non focusable.
  2. If a Darklaf theme is selected have their client properties set accordingly.

Ideally there should be an API for plugin developers to add own buttons to the toolbar (Is there already?). Right now the icons are located at the end of the toolbar instead of the designated button area.

How Has This Been Tested?

See screenshots.

Screenshots (if appropriate):

Visually this only makes a difference with Darklaf.

Before:
toolbar_old

After:
toolbar_new

Types of changes

  • Visual changes.

Checklist:

@pmouawad pmouawad merged commit 0c9606a into apache:master Jun 24, 2020
kkalinin pushed a commit to kkalinin/jmeter that referenced this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants