Skip to content

Commit

Permalink
KAFKA-15489: update QUORUM_FETCH_TIMEOUT_MS_DOC
Browse files Browse the repository at this point in the history
  • Loading branch information
showuon committed Oct 12, 2023
1 parent 41196a1 commit 5a04090
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion raft/src/main/java/org/apache/kafka/raft/LeaderState.java
Expand Up @@ -90,7 +90,7 @@ protected LeaderState(
this.fetchTimer = time.timer(fetchTimeoutMs);
}

// Check if the fetchTimer is expired because we didn't receive fetch/fetchSnapshot request from the majority of
// Check if the fetchTimer is expired because we didn't receive a valid fetch/fetchSnapshot request from the majority of
// the voters within fetch timeout.
public boolean hasMajorityFollowerFetchExpired(long currentTimeMs) {
fetchTimer.update(currentTimeMs);
Expand Down
4 changes: 2 additions & 2 deletions raft/src/main/java/org/apache/kafka/raft/RaftConfig.java
Expand Up @@ -68,8 +68,8 @@ public class RaftConfig {

public static final String QUORUM_FETCH_TIMEOUT_MS_CONFIG = QUORUM_PREFIX + "fetch.timeout.ms";
public static final String QUORUM_FETCH_TIMEOUT_MS_DOC = "Maximum time without a successful fetch from " +
"the current leader before becoming a candidate and triggering an election for voters; Maximum time without " +
"receiving fetch from a majority of the quorum before asking around to see if there's a new epoch for leader.";
"the current leader before becoming a candidate and triggering an election for voters; Maximum time " +
"a leader can go without receiving valid fetch or fetchSnapshot request from a majority of the quorum before resigning.";
public static final int DEFAULT_QUORUM_FETCH_TIMEOUT_MS = 2_000;

public static final String QUORUM_ELECTION_BACKOFF_MAX_MS_CONFIG = QUORUM_PREFIX + "election.backoff.max.ms";
Expand Down

0 comments on commit 5a04090

Please sign in to comment.