Skip to content

Commit

Permalink
KAFKA-7438: Replace Easymock & Powermock with Mockito in RocksDBMetri…
Browse files Browse the repository at this point in the history
…csRecorderGaugesTest (#14190)

Reviewers: Christo Lolov <christololov@gmail.com>, Divij Vaidya <diviv@amazon.com>
  • Loading branch information
bachmanity1 committed Aug 15, 2023
1 parent adc16d0 commit fd6c9f1
Showing 1 changed file with 6 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,11 @@
import static org.apache.kafka.streams.state.internals.metrics.RocksDBMetrics.NUMBER_OF_BACKGROUND_ERRORS;
import static org.apache.kafka.streams.state.internals.metrics.RocksDBMetrics.TOTAL_SST_FILES_SIZE;
import static org.apache.kafka.streams.state.internals.metrics.RocksDBMetrics.USAGE_OF_BLOCK_CACHE;
import static org.easymock.EasyMock.expect;
import static org.easymock.EasyMock.mock;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.CoreMatchers.notNullValue;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.powermock.api.easymock.PowerMock.replay;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

public class RocksDBMetricsRecorderGaugesTest {
private static final String METRICS_SCOPE = "metrics-scope";
Expand Down Expand Up @@ -212,11 +211,8 @@ private void runAndVerifySumOfProperties(final String propertyName) throws Excep

final long recordedValue1 = 5L;
final long recordedValue2 = 3L;
expect(dbToAdd1.getAggregatedLongProperty(ROCKSDB_PROPERTIES_PREFIX + propertyName))
.andStubReturn(recordedValue1);
expect(dbToAdd2.getAggregatedLongProperty(ROCKSDB_PROPERTIES_PREFIX + propertyName))
.andStubReturn(recordedValue2);
replay(dbToAdd1, dbToAdd2);
when(dbToAdd1.getAggregatedLongProperty(ROCKSDB_PROPERTIES_PREFIX + propertyName)).thenReturn(recordedValue1);
when(dbToAdd2.getAggregatedLongProperty(ROCKSDB_PROPERTIES_PREFIX + propertyName)).thenReturn(recordedValue2);

verifyMetrics(streamsMetrics, propertyName, recordedValue1 + recordedValue2);
}
Expand All @@ -235,11 +231,8 @@ private void runAndVerifyBlockCacheMetricsWithSingleCache(final String propertyN
recorder.addValueProviders(SEGMENT_STORE_NAME_2, dbToAdd2, cacheToAdd1, statisticsToAdd2);

final long recordedValue = 5L;
expect(dbToAdd1.getAggregatedLongProperty(ROCKSDB_PROPERTIES_PREFIX + propertyName))
.andStubReturn(recordedValue);
expect(dbToAdd2.getAggregatedLongProperty(ROCKSDB_PROPERTIES_PREFIX + propertyName))
.andStubReturn(recordedValue);
replay(dbToAdd1, dbToAdd2);
when(dbToAdd1.getAggregatedLongProperty(ROCKSDB_PROPERTIES_PREFIX + propertyName)).thenReturn(recordedValue);
when(dbToAdd2.getAggregatedLongProperty(ROCKSDB_PROPERTIES_PREFIX + propertyName)).thenReturn(recordedValue);

verifyMetrics(streamsMetrics, propertyName, recordedValue);
}
Expand Down

0 comments on commit fd6c9f1

Please sign in to comment.