-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-12454: Add ERROR logging on kafka-log-dirs when given brokerIds do not exist in current kafka cluster #10304
Merged
chia7712
merged 14 commits into
apache:trunk
from
wenbingshen:addErrorLog2LogDirsCommand
Mar 18, 2021
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e71e5a4
KAFKA-12454:Add ERROR logging on kafka-log-dirs when given brokerIds …
wenbingshen 91fd305
KAFKA-12454:Add ERROR logging on kafka-log-dirs when given brokerIds …
wenbingshen b473a44
KAFKA-12454:Add ERROR logging on kafka-log-dirs when given brokerIds …
wenbingshen a4d6ae7
KAFKA-12454:Add ERROR logging on kafka-log-dirs when given brokerIds …
wenbingshen 2b623e2
Merge branch 'trunk' into addErrorLog2LogDirsCommand
fefdef9
KAFKA-12454:Add ERROR logging on kafka-log-dirs when given brokerIds …
c88b348
KAFKA-12454:Add ERROR logging on kafka-log-dirs when given brokerIds …
wenbingshen 848822f
KAFKA-12454:Add ERROR logging on kafka-log-dirs when given brokerIds …
wenbingshen 587800d
Merge remote-tracking branch 'sri/trunk' into KAFKA-12454
wenbingshen 1e26832
KAFKA-12454:Add ERROR logging on kafka-log-dirs when given brokerIds …
5641815
Merge branch 'trunk' into addErrorLog2LogDirsCommand
b245e5f
KAFKA-12454:Add ERROR logging on kafka-log-dirs when given brokerIds …
3565cca
Merge branch 'trunk' into addErrorLog2LogDirsCommand
24f520f
KAFKA-12454:Add ERROR logging on kafka-log-dirs when given brokerIds …
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 changes: 76 additions & 0 deletions
76
core/src/test/scala/unit/kafka/admin/LogDirsCommandTest.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
/** | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package kafka.admin | ||
|
||
import java.io.{ByteArrayOutputStream, PrintStream} | ||
import java.nio.charset.StandardCharsets | ||
|
||
import kafka.integration.KafkaServerTestHarness | ||
import kafka.server.KafkaConfig | ||
import kafka.utils.TestUtils | ||
import org.junit.jupiter.api.Assertions.assertTrue | ||
import org.junit.jupiter.api.Test | ||
|
||
import scala.collection.Seq | ||
|
||
class LogDirsCommandTest extends KafkaServerTestHarness { | ||
|
||
def generateConfigs: Seq[KafkaConfig] = { | ||
TestUtils.createBrokerConfigs(1, zkConnect) | ||
.map(KafkaConfig.fromProps) | ||
} | ||
|
||
@Test | ||
def checkLogDirsCommandOutput(): Unit = { | ||
val byteArrayOutputStream = new ByteArrayOutputStream | ||
val printStream = new PrintStream(byteArrayOutputStream, false, StandardCharsets.UTF_8.name()) | ||
//input exist brokerList | ||
LogDirsCommand.describe(Array("--bootstrap-server", brokerList, "--broker-list", "0", "--describe"), printStream) | ||
val existingBrokersContent = new String(byteArrayOutputStream.toByteArray, StandardCharsets.UTF_8) | ||
val existingBrokersLineIter = existingBrokersContent.split("\n").iterator | ||
|
||
assertTrue(existingBrokersLineIter.hasNext) | ||
assertTrue(existingBrokersLineIter.next().contains(s"Querying brokers for log directories information")) | ||
|
||
//input nonexistent brokerList | ||
byteArrayOutputStream.reset() | ||
LogDirsCommand.describe(Array("--bootstrap-server", brokerList, "--broker-list", "0,1,2", "--describe"), printStream) | ||
val nonExistingBrokersContent = new String(byteArrayOutputStream.toByteArray, StandardCharsets.UTF_8) | ||
val nonExistingBrokersLineIter = nonExistingBrokersContent.split("\n").iterator | ||
|
||
assertTrue(nonExistingBrokersLineIter.hasNext) | ||
assertTrue(nonExistingBrokersLineIter.next().contains(s"ERROR: The given brokers do not exist from --broker-list: 1,2. Current existent brokers: 0")) | ||
|
||
//input duplicate ids | ||
byteArrayOutputStream.reset() | ||
LogDirsCommand.describe(Array("--bootstrap-server", brokerList, "--broker-list", "0,0,1,2,2", "--describe"), printStream) | ||
val duplicateBrokersContent = new String(byteArrayOutputStream.toByteArray, StandardCharsets.UTF_8) | ||
val duplicateBrokersLineIter = duplicateBrokersContent.split("\n").iterator | ||
|
||
assertTrue(duplicateBrokersLineIter.hasNext) | ||
assertTrue(duplicateBrokersLineIter.next().contains(s"ERROR: The given brokers do not exist from --broker-list: 1,2. Current existent brokers: 0")) | ||
|
||
//use all brokerList for current cluster | ||
byteArrayOutputStream.reset() | ||
LogDirsCommand.describe(Array("--bootstrap-server", brokerList, "--describe"), printStream) | ||
val allBrokersContent = new String(byteArrayOutputStream.toByteArray, StandardCharsets.UTF_8) | ||
val allBrokersLineIter = allBrokersContent.split("\n").iterator | ||
|
||
assertTrue(allBrokersLineIter.hasNext) | ||
assertTrue(allBrokersLineIter.next().contains(s"Querying brokers for log directories information")) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you input duplicate ids and the check the output does not include duplicates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chia7712 I have added the duplicate ids test and it passed.