Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Exclude KIP-500.md from rat check #10354

Merged
merged 1 commit into from Mar 18, 2021
Merged

MINOR: Exclude KIP-500.md from rat check #10354

merged 1 commit into from Mar 18, 2021

Conversation

jolshan
Copy link
Contributor

@jolshan jolshan commented Mar 18, 2021

Builds are failing since this file does not have a license. Similar .md files do not seem to have licenses, so I've added this file to the exclude list.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Contributor

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hachikuji
Copy link
Contributor

Thanks for fixing this so quickly.

@vvcephei
Copy link
Contributor

Thanks, @jolshan ! Will this need to be cherry-picked to 2.8?

@cmccabe
Copy link
Contributor

cmccabe commented Mar 18, 2021

Thanks, @jolshan

@mumrah
Copy link
Contributor

mumrah commented Mar 18, 2021

Maybe we should exclude all markdown files from the license check?

@ijuma ijuma merged commit a065fa5 into apache:trunk Mar 18, 2021
@ijuma
Copy link
Contributor

ijuma commented Mar 18, 2021

Merged to unbreak the build, we can improve further in future PRs.

ijuma pushed a commit that referenced this pull request Mar 18, 2021
Builds are failing since this file does not have a license. Similar .md files do not seem to have licenses,
so I've added this file to the exclude list.
@ijuma
Copy link
Contributor

ijuma commented Mar 18, 2021

Also cherry-picked to 2.8.

ijuma added a commit to confluentinc/kafka that referenced this pull request Mar 19, 2021
Conflicts:
* build.gradle: keep `dependencySubstitution` Confluent addition in
`resolutionStrategy` and take upstream changes.

Commits:
* apache-github/trunk:
  KAFKA-12503: inform threads to resize their cache instead of doing so for them (apache#10356)
  KAFKA-10697: Remove ProduceResponse.responses (apache#10332)
  MINOR: Exclude KIP-500.md from rat check (apache#10354)
  MINOR: Move `configurations.all` to be a child of `allprojects` (apache#10349)
  MINOR: Remove use of `NoSuchElementException` in `KafkaMetadataLog` (apache#10344)
  MINOR: Start the broker-to-controller channel for request forwarding (apache#10340)
  KAFKA-12382: add a README for KIP-500 (apache#10227)
  MINOR: Fix BaseHashTable sizing (apache#10334)
  KAFKA-10357: Add setup method to internal topics (apache#10317)
  MINOR: remove redundant null check when testing specified type (apache#10314)
  KAFKA-12293: Remove JCenter from buildscript and delete buildscript.gradle
  KAFKA-12491: Make rocksdb an `api` dependency for `streams` (apache#10341)
  KAFKA-12454: Add ERROR logging on kafka-log-dirs when given brokerIds do not  exist in current kafka cluster (apache#10304)
  KAFKA-12459; Use property testing library for raft event simulation tests (apache#10323)
  MINOR: fix failing ZooKeeper system tests (apache#10297)
  MINOR: fix client_compatibility_features_test.py (apache#10292)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants