KAFKA-12601: Remove deprecated delegation.token.master.key in 3.0
#10459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was only deprecated in 2.8, but it would be nice not to have the racially charged term `master` in 3.0.
ijuma
changed the title
delegation.token.master.keydelegation.token.master.key in 3.0
mimaison
reviewed
Apr 1, 2021
| @@ -1292,8 +1290,7 @@ object KafkaConfig { | |||
| .define(SaslLoginRefreshMinPeriodSecondsProp, SHORT, Defaults.SaslLoginRefreshMinPeriodSeconds, MEDIUM, SaslLoginRefreshMinPeriodSecondsDoc) | |||
| .define(SaslLoginRefreshBufferSecondsProp, SHORT, Defaults.SaslLoginRefreshBufferSeconds, MEDIUM, SaslLoginRefreshBufferSecondsDoc) | |||
| /** ********* Delegation Token Configuration ****************/ | |||
| .define(DelegationTokenSecretKeyAliasProp, PASSWORD, null, MEDIUM, DelegationTokenSecretKeyAliasDoc) | |||
| .define(DelegationTokenSecretKeyProp, PASSWORD, null, MEDIUM, DelegationTokenSecretKeyDoc) | |||
| .define(DelegationTokenSecretKeyProp, PASSWORD, MEDIUM, DelegationTokenSecretKeyDoc) | |||
There was a problem hiding this comment.
It looks like some logic depends on having null as default as a bunch of tests are failing with:
org.apache.kafka.common.config.ConfigException: Missing required configuration "delegation.token.secret.key" which has no default value.
There was a problem hiding this comment.
Will fix if we agree that this is a good idea. :) It's more aggressive than I would usually recommend, so I'm looking for additional opinions.
There was a problem hiding this comment.
@mimaison so, what's your take? Should we remove this for 3.0, or keep it until 4.0?
|
Thinking about this more, since this config was previously required and the KIP-692 configs were not deprecated in time for removal in 3.0, I think we should remove this in 4.0. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was only deprecated in 2.8, but it would be nice not to have the
racially charged term
masterin 3.0.Committer Checklist (excluded from commit message)