Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-12396 added a nullcheck before trying to retrieve a key #10548

Merged
merged 10 commits into from Apr 30, 2021
Merged

KAFKA-12396 added a nullcheck before trying to retrieve a key #10548

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
26395a5
KAFKA-12396 added a nullcheck before trying to retrieve a key
Apr 16, 2021
b06e7ae
KAFKA-12396 elevated nullcheck to store types and provided some unit …
Apr 16, 2021
8091bf4
KAFKA-12396 removed unnecessary checks from MeteredKeyValueStore and …
Apr 21, 2021
c6703a0
KAFKA-12396 got rid of the null check in RocksDBStore
Apr 21, 2021
983cc95
KAFKA-12396 reverted RockDBStore to it's original state
Apr 22, 2021
7142aa2
KAFKA-12396 checkstyle errors fixed
Apr 22, 2021
c9aef82
KAFKA-12396 new checks\tests for MeteredSessionStoreTest, small refac…
Apr 22, 2021
5e61459
KAFKA-12396 cosmetic changes in tests signatures
Apr 22, 2021
3d6bc9b
KAFKA-12396 removed unused import
Apr 26, 2021
12038c0
KAFKA-12396 removed obsolete test
Apr 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
View file
Open in desktop
Expand Up @@ -326,6 +326,7 @@ public <PS extends Serializer<P>, P> KeyValueIterator<Bytes, byte[]> prefixScan(

@Override
public synchronized byte[] get(final Bytes key) {
Objects.requireNonNull(key, "key cannot be null");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add this to MeteredKeyValueStore instead -- this way, we get the same guard for the in-memory key-value store (or other custom stores).

We should also add this check to other methods that accept a key, like put, putIfAbsent etc...

Furthermore, we should also add it for other store types, ie, MeteredTimestampedKeyValueStore, MeteredWindowedStore, MeteredTimestampedWindowStore and MeteredSessionStore.

Last, but not least, we should add corresponding unit tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check can be remove, as we do the check in the "metered" store that will wrap this one.

validateStoreOpen();
try {
return dbAccessor.get(key.get());
Expand Down