Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: LogLoader: Add log identifier in few missing areas #10819

Merged
merged 1 commit into from Jun 4, 2021
Merged

MINOR: LogLoader: Add log identifier in few missing areas #10819

merged 1 commit into from Jun 4, 2021

Conversation

kowshik
Copy link
Contributor

@kowshik kowshik commented Jun 4, 2021

While reading the code, I noticed that LogLoader had a few points where the log identifier was not printed as part of the log message. I've fixed it in this PR.

Tests:
Rely on existing tests.

@kowshik kowshik changed the title MINOR: LogLoader: Add log identifier at few missing areas MINOR: LogLoader: Add log identifier in few missing areas Jun 4, 2021
@kowshik
Copy link
Contributor Author

kowshik commented Jun 4, 2021

@junrao Please could you help review this small change?

junrao
junrao approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@junrao junrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kowshik : Thanks for the PR. LGTM.

@junrao junrao merged commit 5ef9022 into apache:trunk Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junrao junrao junrao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kowshik @junrao