Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-12849: KIP-744 TaskMetadata ThreadMetadata StreamsMetadata as API #10840

Merged
merged 6 commits into from Jun 25, 2021
Merged

KAFKA-12849: KIP-744 TaskMetadata ThreadMetadata StreamsMetadata as API #10840

merged 6 commits into from Jun 25, 2021

Commits on Jun 23, 2021

  1. KAFKA-12849: KIP-744 TaskMetadata ThreadMetadata StreamsMetadata as API 

    Implementation of KIP-744.

Creates new Interfaces for TaskMetadata, ThreadMetadata, and
StreamsMetadata, providing internal implementations for each of them.

Deprecates current TaskMetadata, ThreadMetadata under o.a.k.s.processor,
and SreamsMetadata under a.o.k.s.state.

Updates references on internal classes from deprecated classes to new interfaces.

Deprecates methods on KStreams returning deprecated ThreadMeatada and
StreamsMetadta, and provides new ones returning the new interfaces.

Update Javadocs referencing to deprecated classes and methods to point
to the right ones.
    @jlprat
    jlprat committed Jun 23, 2021
    Copy the full SHA
    709e3b3 View commit details
    Browse the repository at this point in the history

  2. Applies suggestions regarding method names, refactors, and formatting

    @jlprat
    jlprat committed Jun 23, 2021
    Copy the full SHA
    1945750 View commit details
    Browse the repository at this point in the history

  3. Add tests for equals hashcode and unmodifiable collections

    @jlprat
    jlprat committed Jun 23, 2021
    Copy the full SHA
    a419c89 View commit details
    Browse the repository at this point in the history

  4. Add guard against null otherwise StreamThreadTest tests were failing

    @jlprat
    jlprat committed Jun 23, 2021
    Copy the full SHA
    a6a0bec View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2021

  1. Applies feedback 

    It includes
- Split equality tests by cases
- Add JavaDoc on methods
- Fix formatting
- Use proper assertThat instead of other means
- Fix names, use the proper names consistently
    @jlprat
    jlprat committed Jun 25, 2021
    Copy the full SHA
    4403e8c View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Bruno Cadonna <cadonna@apache.org>
    @jlprat @cadonna
    jlprat and cadonna committed Jun 25, 2021
    Copy the full SHA
    8defa04 View commit details
    Browse the repository at this point in the history