Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-13056; Do not rely on broker for snapshots if controller is co-resident #11013

Merged
merged 2 commits into from Jul 10, 2021
Merged

KAFKA-13056; Do not rely on broker for snapshots if controller is co-resident #11013

merged 2 commits into from Jul 10, 2021

Conversation

hachikuji
Copy link
Contributor

When a node is serving as both broker and controller, we should only rely on the controller to write new snapshots.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

cmccabe
cmccabe approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@cmccabe cmccabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make a test where we set snapshotter = None but then trigger what would normally be the conditions for making a snapshot?

LGTM after that

showuon
showuon approved these changes Jul 10, 2021
View reviewed changes
Copy link
Contributor

@showuon showuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hachikuji hachikuji merged commit 5ef962b into apache:trunk Jul 10, 2021
hachikuji added a commit that referenced this pull request Jul 10, 2021
@hachikuji
KAFKA-13056; Do not rely on broker for snapshots if controller is co-…
e9e181b 
…resident (#11013)

When a node is serving as both broker and controller, we should only rely on the controller to write new snapshots.

Reviewers: Luke Chen <showuon@gmail.com>, Colin P. McCabe <cmccabe@apache.org>
@ijuma ijuma added the kraft label Aug 11, 2021
xdgrulez pushed a commit to xdgrulez/kafka that referenced this pull request Dec 22, 2021
@hachikuji
KAFKA-13056; Do not rely on broker for snapshots if controller is co-…
a0b9ce9 
…resident (apache#11013)

When a node is serving as both broker and controller, we should only rely on the controller to write new snapshots.

Reviewers: Luke Chen <showuon@gmail.com>, Colin P. McCabe <cmccabe@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmccabe cmccabe cmccabe approved these changes

@showuon showuon showuon approved these changes

Assignees
No one assigned
Labels
kraft
Projects
None yet
Milestone
No milestone
4 participants
@hachikuji @cmccabe @showuon @ijuma