KAFKA-13127; Fix stray topic partition deletion for kraft #11118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmccabe
reviewed
Jul 23, 2021
cmccabe
reviewed
Jul 23, 2021
core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala
Show resolved
Hide resolved
cmccabe
approved these changes
Jul 23, 2021
mumrah
approved these changes
Jul 23, 2021
There was a problem hiding this comment.
Thanks @hachikuji. The additional logging is much appreciated here :)
One minor comment, otherwise LGTM
cmccabe
pushed a commit
that referenced
this pull request
Jul 23, 2021
This patch fixes BrokerMetadataPublisher.findGhostReplicas (renamed to findStrayPartitions) so that it returns the stray partitions. Previously it was returning the non-stray partitions. This caused all of these partitions to get deleted on startup by mistake. Reviewers: Colin P. McCabe <cmccabe@apache.org>, José Armando García Sancio <jsancio@gmail.com>
xdgrulez
pushed a commit
to xdgrulez/kafka
that referenced
this pull request
Dec 22, 2021
This patch fixes BrokerMetadataPublisher.findGhostReplicas (renamed to findStrayPartitions) so that it returns the stray partitions. Previously it was returning the non-stray partitions. This caused all of these partitions to get deleted on startup by mistake. Reviewers: Colin P. McCabe <cmccabe@apache.org>, José Armando García Sancio <jsancio@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes
BrokerMetadataPublisher.findGhostReplicas(renamed tofindStrayPartitions) so that it returns the stray partitions. Previously it was returning the non-stray partitions.Committer Checklist (excluded from commit message)