Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-3409: handle CommitFailedException in MirrorMaker #1115

Closed
wants to merge 4 commits into from
Closed

KAFKA-3409: handle CommitFailedException in MirrorMaker #1115

wants to merge 4 commits into from

Conversation

hachikuji
Copy link
Contributor

No description provided.

@hachikuji
Copy link
Contributor Author

cc @becketqin @SinghAsDev @ijuma

This is not significantly different from Ashish's patch, but I've added a log statement to give users more guidance if they see this occurring regularly. I think there's more we could be doing internally to mitigate this problem. For example, maybe it makes sense to set a default max.poll.records. Also we currently just block in the send loop after polling the records in receive(), but we probably should abort that loop immediately when the session timeout expires since we'll have no chance of committing offsets anyway. We could try to tackle some of this in this patch, but I'm thinking of opening a separate JIRA since a bigger change will be harder to get into 0.10. Thoughts?

@ijuma
Copy link
Contributor

ijuma commented Mar 22, 2016

@hachikuji, filing a separate JIRA for the additional improvements sounds good to me.

@ijuma
Copy link
Contributor

ijuma commented Mar 22, 2016

LGTM

@SinghAsDev
Copy link
Contributor

Looks good @hachikuji !

@guozhangwang
Copy link
Contributor

LGTM.

@asfgit asfgit closed this in 20c3135 Mar 23, 2016
asfgit pushed a commit that referenced this pull request Mar 23, 2016
@hachikuji @guozhangwang
KAFKA-3409: handle CommitFailedException in MirrorMaker
2835e73 
Author: Jason Gustafson <jason@confluent.io>

Reviewers: Ismael Juma, Ashish Singh, Guozhang Wang

Closes #1115 from hachikuji/KAFKA-3409

(cherry picked from commit 20c3135)
Signed-off-by: Guozhang Wang <wangguoz@gmail.com>
@guozhangwang
Copy link
Contributor

Merged to trunk and 0.10.0.

zsolt-donca added a commit to zsolt-donca/kafka that referenced this pull request Jun 5, 2018
@zsolt-donca
Applied the code changes from apache#1115
890b187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@hachikuji @ijuma @SinghAsDev @guozhangwang