Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-13399 towards scala3 #11432

Closed
wants to merge 5 commits into from
Closed

KAFKA-13399 towards scala3 #11432

wants to merge 5 commits into from

Commits on Apr 6, 2022

  1. KAFKA-13399 Avoid Shadowing 

    Scala 3 compiler is not so friendly with shadowing and reports errors where Scala 2 wasn't.
    @jlprat
    jlprat committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    a4817a9 View commit details
    Browse the repository at this point in the history

  2. KAFKA-13399 No automatic widening in Numeric types 

    Scala 3 doesn't automatically convert `Short` to `Int` or `Int` to `Long` at will as in Scala 2. Changes in here help the typer by manually forcing the conversions.
    @jlprat
    jlprat committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    1dd2216 View commit details
    Browse the repository at this point in the history

  3. KAFKA-13399 Remove redundant parens 

    Scala 2 was more lax about calling with empty parenthesis a method without parenthesis. This became stricter in Scala 3.
    @jlprat
    jlprat committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    6175fda View commit details
    Browse the repository at this point in the history

  4. KAFKA-13399 More explicit with types 

    Scala 3 changed a bit in the area of type inference and in some cases it picks the most general type, causing in our case some trouble as this is not public but package protected.
In other cases, the typer wasn't able to infer the proper one, forcing it to be manually set.
    @jlprat
    jlprat committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    a001b8a View commit details
    Browse the repository at this point in the history

  5. KAFKA-13399 Workaround for SAM conversion with overloading. 

    This is a reported bug that unfortunately can't be fixed easily without breakage on Scala's side. For further information check scala/scala3#13549
    @jlprat
    jlprat committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    ddd25c6 View commit details
    Browse the repository at this point in the history