New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: Add license header in suppressions.xml #11753
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ruanwenjun , thanks for the patch. Left a comment.
@@ -1,9 +1,24 @@ | |||
|
|||
<?xml version="1.0"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary to add this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review.
To be honestly, I am not sure if this is must, but from the demo provided by checkstyle
, it contains this header.
So it might be better to add this header.
https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/suppressions-filter.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, from the XML spec [1], it said:
XML documents SHOULD begin with an XML declaration which specifies the version of XML being used.
Adding it to follow the spec suggestion is good to me.
1: https://www.w3.org/TR/xml/#sec-prolog-dtd
failed tests are unrelated:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the patch, and help format the license header in xml files.
I find there is no Apache License header in
suppressions.xml
, this pr is adding the license header.Committer Checklist (excluded from commit message)