KAFKA-13688: Fix a couple incorrect metrics in KafkaController #11799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chb2ab
force-pushed
the
trunk
branch
2 times, most recently
from
79d3604
to
b3ce2e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KAFKA-13688: This change removes unnecessary and incorrect set creations over the topics to be deleted during
update metrics, computing both replicasToDeleteCount and ineligibleReplicasToDeleteCount in a single scan.
Future metrics calculated over topics to be deleted should build on this scan for better performance.
Committer Checklist (excluded from commit message)