Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-1372: separate 400 error from 500 error in RestClient #11838

Closed
wants to merge 1 commit into from

Conversation

blcksrx
Copy link
Contributor

@blcksrx blcksrx commented Mar 3, 2022

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@blcksrx
Copy link
Contributor Author

blcksrx commented Mar 7, 2022

@kirktrue

@kirktrue
Copy link
Contributor

kirktrue commented Mar 9, 2022

Thanks for the PR! It looks good to me. You need to get a committer to look at this in order to get it merged in. Perhaps a git blame can turn up someone who's worked on this that you can ping.

@blcksrx
Copy link
Contributor Author

blcksrx commented Mar 9, 2022

@mimaison

@mimaison
Copy link
Member

Thanks for the PR @blcksrx ! I'll try to take a look in the next few days

@C0urante
Copy link
Contributor

C0urante commented Apr 8, 2022

There's also #11844, which addresses the same issue and takes a slightly different approach that preserves the exact status that the client received from the request to the forwarded worker in the response to the REST API.

@C0urante
Copy link
Contributor

C0urante commented Apr 8, 2022

BTW, probably want to update the ticket number in the title to 13702.

@mimaison
Copy link
Member

We merged #12320, so closing this PR

@mimaison mimaison closed this Jul 20, 2022
@blcksrx blcksrx deleted the KAFKA-13702 branch July 20, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants