Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Small improvements for KAFKA-13587 #11918

Merged
merged 1 commit into from Mar 21, 2022
Merged

MINOR: Small improvements for KAFKA-13587 #11918

merged 1 commit into from Mar 21, 2022

Conversation

dengziming
Copy link
Member

More detailed description of your change

  1. Fix a bug: comparing values of types Byte and LeaderRecoveryState using == will always yield false
  2. Show LeaderRecoveryState in MetadataShell

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@dengziming
Copy link
Member Author

cc @jsancio

cmccabe
cmccabe approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@cmccabe cmccabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @dengziming .

@cmccabe cmccabe merged commit d449f85 into apache:trunk Mar 21, 2022
@dengziming dengziming deleted the minor-recovery-state branch October 8, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmccabe cmccabe cmccabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dengziming @cmccabe