Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-13620: Use different metric name for KRaft SocketServer #12093

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

dengziming
Copy link
Member

@dengziming dengziming commented Apr 24, 2022

More detailed description of your change
In traditional we only have one SocketServer and one KafkaRequestHandlerPool in a process. In KRaft cluster, especially in co-resident mode, there may be multiple SocketServer and KafkaRequestHandlerPool, so we should avoid using the same MetricName.
I just added a prefix for the SocketServer and KafkaRequestHandlerPool in ControllerServer, to differentiate between the ones in BrokerServer.

Note that I didn't change Acceptor and Processor, since their metric name tags contain a listenerName, which will always be different for ControllerServer and BrokerServer.

Summary of testing strategy (including rationale)

  1. integration tests.
  2. Tested locally, now there are 2 KafkaRequestHandlerPool metrics in KRaft co-resident mode, compared to only one before.

image

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant