HOTFIX: Only measure in nano when producer metadata refresh is required #12102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rodesai for a quick look. |
mjsax
approved these changes
Apr 27, 2022
|
Hi @cadonna could you please lmk if I can cherry-pick it to 3.2 as well? |
|
@guozhangwang I do not think we need this hotfix on 3.2 since #11805 is not present on the 3.2 branch. |
|
Ah yes :) my bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added the metadata wait time in total blocked time (#11805). But we added it in the critical path of
sendwhich is called per-record, whereas metadata refresh only happens rarely. This way the cost oftime.nanosbecomes unnecessarily significant as we call it twice per record.This PR moves the call to inside the
waitOnMetadatacallee and only when we do need to wait for a metadata refresh round-trip (i.e. we are indeed blocking).Committer Checklist (excluded from commit message)