New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: Enable some AdminClient integration tests #12110
Conversation
4e50982
to
6ceb53a
Compare
a9969bd
to
1eaeaa1
Compare
1eaeaa1
to
01c0de3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dengziming Thanks, just a couple small comments. By the way, let me know if you have any other conversion patches and I can review them.
core/src/test/scala/integration/kafka/api/AdminClientWithPoliciesIntegrationTest.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Left some comments.
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala
Show resolved
Hide resolved
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala
Outdated
Show resolved
Hide resolved
Also, the 2 failed tests are introduced by this PR.
I checked the topicID issue, it looks like there's a race condition for metadata cache, so that the metadata cache will return ZERO_UUID if empty: Thanks. |
@showuon These 2 tests can be fixed by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
More detailed description of your change
Enable KRaft in AdminClientWithPoliciesIntegrationTest and PlaintextAdminIntegrationTest
There are some tests not enabled or not as expected yet:
Summary of testing strategy (including rationale)
QA
Committer Checklist (excluded from commit message)