Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-13891: reset generation when syncgroup failed with REBALANCE_IN_PROGRESS #12140

Merged
merged 2 commits into from Jun 13, 2022
Merged

KAFKA-13891: reset generation when syncgroup failed with REBALANCE_IN_PROGRESS #12140

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc1d809
minor: reset generation when syncgroup failed with REBALANCE_IN_PROGRESS
aiquestion May 9, 2022
8d425b0
add test and add comment
aiquestion May 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
View file
Open in desktop
Expand Up @@ -807,6 +807,7 @@ public void handle(SyncGroupResponse syncResponse,
} else if (error == Errors.REBALANCE_IN_PROGRESS) {
log.info("SyncGroup failed: The group began another rebalance. Need to re-join the group. " +
"Sent generation was {}", sentGeneration);
resetStateOnResponseError(ApiKeys.SYNC_GROUP, error, false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to add a comment here to explain why we need to reset generation ID here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comment & unit test. thanks~

future.raise(error);
} else if (error == Errors.FENCED_INSTANCE_ID) {
// for sync-group request, even if the generation has changed we would not expect the instance id
Expand Down