Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Fix method javadoc and typo in comments #12435

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
+2 −3
Open

MINOR: Fix method javadoc and typo in comments #12435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions core/src/main/scala/kafka/server/DelayedOperation.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,7 @@ final class DelayedOperationPurgatory[T <: DelayedOperation](purgatoryName: Stri
}

/*
* Return the watch list of the given key, note that we need to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing this line, could we update the comment to reflect the current implementation?

* grab the removeWatchersLock to avoid the operation being added to a removed watcher list
* Note that we need to grab the removeWatchersLock to avoid the operation being added to a removed watcher list
*/
private def watchForOperation(key: Any, operation: T): Unit = {
val wl = watcherList(key)
Expand Down
2 changes: 1 addition & 1 deletion release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#

"""
Utility for creating release candidates and promoting release candidates to a final relase.
Utility for creating release candidates and promoting release candidates to a final release.

Usage: release.py [subcommand]

Expand Down