KAFKA-14151: validate offsets of input records before writing them file #12516
+60
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent81jiang
changed the title
junrao
reviewed
Aug 19, 2022
There was a problem hiding this comment.
@vincent81jiang : Thanks for the PR. Left a couple of comments.
| @@ -176,10 +179,28 @@ class LogSegment private[log] (val log: FileRecords, | |||
| throw new LogSegmentOffsetOverflowException(this, offset) | |||
| } | |||
|
|
|||
| /** | |||
| * Validate that offsets of records are monotonically increasing and are in [offsetLowerBound, offsetUpperBound] range. | |||
There was a problem hiding this comment.
We are just verifying the offsets of record batches, not individual records.
There was a problem hiding this comment.
Right. Will fix the comment.
| private def ensureOffsetsInRangeForRecords(records: Records, offsetLowerBound: Long, offsetUpperBound: Long): Unit = { | ||
| var offsetLowerBoundForBatch = offsetLowerBound | ||
| records.batches.forEach { batch => | ||
| if (batch.baseOffset < offsetLowerBoundForBatch || batch.lastOffset > offsetUpperBound || batch.baseOffset > batch.lastOffset) { |
There was a problem hiding this comment.
Was the issue reported issue in the jira on the leader or the follower? If it's on the leader, currently, each leader append only has one batch. I am wondering if the validation should be done inside LogValidator.validateMessagesAndAssignOffsets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate offsets of records before writing to log segment file.
Committer Checklist (excluded from commit message)