KAFKA-3602: rename RecordAccumulator dequeFor() and fix usage #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -401,10 +401,14 @@ public boolean hasUnsent() { | |||
| return batches; | |||
| } | |||
|
|
|||
| private Deque<RecordBatch> getDeque(TopicPartition tp) { | |||
There was a problem hiding this comment.
NIT: On a separate thread it was mentioned that we do not follow getter convention. Would it make sense to stick to that here as well? Maybe @ijuma will have some suggestion here.
There was a problem hiding this comment.
Yeah, I'm aware of the convention. I chose getDeque() here because it paired nicely with getOrCreateDeque() and I couldn't come up with a way to use that convention for the latter.
There was a problem hiding this comment.
TBH, I do not have any better suggestion as well. Maybe it is OK to have it the way it is.
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
gfodor
pushed a commit
to AltspaceVR/kafka
that referenced
this pull request
Jun 3, 2016
Author: Jason Gustafson <jason@confluent.io> Reviewers: Grant Henke <granthenke@gmail.com>, Ashish Singh <asingh@cloudera.com>, Ismael Juma <ismael@juma.me.uk> Closes apache#1254 from hachikuji/KAFKA-3602
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.