KAFKA-3608: Fix ZooKeeper structures and output format in documentation #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also have https://cwiki.apache.org/confluence/display/KAFKA/Kafka+data+structures+in+Zookeeper, @gwenshap which of the two copies do we want to maintain going forward? The one in the Git repo? |
|
Obviously the one in Git :) Any chance we could auto-generate those too? Maybe @vahidhashemian can do a follow-on? Or @granthenke, since he auto-generated the protocol? |
|
Not sure what is involved in auto-generate. If @granthenke sends me some pointers I can give it a try :) |
asfgit
pushed a commit
that referenced
this pull request
May 10, 2016
Author: Vahid Hashemian <vahidhashemian@us.ibm.com> Reviewers: Gwen Shapira Closes #1257 from vahidhashemian/KAFKA-3608 (cherry picked from commit 18226ff) Signed-off-by: Gwen Shapira <cshapi@gmail.com>
|
For now, @vahidhashemian, can you just open a JIRA? Just so we won't lose track of the requirement? |
|
@gwenshap Sure, will do shortly. |
gfodor
pushed a commit
to AltspaceVR/kafka
that referenced
this pull request
Jun 3, 2016
Author: Vahid Hashemian <vahidhashemian@us.ibm.com> Reviewers: Gwen Shapira Closes apache#1257 from vahidhashemian/KAFKA-3608
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.