KAFKA-3614: Consolidate duplicate code in KGroupedTableImpl #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two methods aggregate() and reduce() share common code that is consolidated in this patch.
|
It seems another pull request was already created for this. Even though there was no sign from the corresponding JIRA ticket it was already picked up by someone. I'm closing this one. |
|
Sorry for this bad experience... |
|
@vahidhashemian: Sorry for the confusion. I suppose that the crunch time before the upcoming 0.10 release was the reason for this. |
|
@vahidhashemian: I checked the Kafka JIRA ticket quickly. It looks like there was a glitch in the GitHub <-> JIRA integration, as the original PR (#1262; was filed 2 days prior to yours) was not detected and tracked by the ASF JIRA, so it looked as if no one had started working on it yet. In any case, thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two methods aggregate() and reduce() share common code that is consolidated in this patch.