Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Get console output in quickstart examples #12719

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

lucasbru
Copy link
Member

@lucasbru lucasbru commented Oct 6, 2022

Quickstart examples didn't produce any console output, since it was missing a logger implementation in the classpath.

Also some minor cleanups.

Tested by creating a test project and running the code.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Quickstart examples didn't produce any console output, since
it was missing a logger implementation in the classpath.

Also some minor cleanups.
@lucasbru
Copy link
Member Author

lucasbru commented Oct 6, 2022

@cadonna would you want to have a look?

@lucasbru
Copy link
Member Author

Test failures are unrelated

Copy link
Contributor

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @lucasbru, LGTM

@bbejeck
Copy link
Contributor

bbejeck commented Oct 24, 2022

Failure unrelated merging

@bbejeck bbejeck merged commit 732887b into apache:trunk Oct 24, 2022
@bbejeck
Copy link
Contributor

bbejeck commented Oct 24, 2022

merged #12719 into trunk

guozhangwang pushed a commit to guozhangwang/kafka that referenced this pull request Jan 25, 2023
Quickstart examples didn't produce any console output, since it was missing a logger implementation in the classpath.

Also some minor cleanups.

Tested by creating a test project and running the code.
rutvijmehta-harness pushed a commit to rutvijmehta-harness/kafka that referenced this pull request Feb 9, 2024
Quickstart examples didn't produce any console output, since it was missing a logger implementation in the classpath.

Also some minor cleanups.

Tested by creating a test project and running the code.
rutvijmehta-harness added a commit to rutvijmehta-harness/kafka that referenced this pull request Feb 9, 2024
Quickstart examples didn't produce any console output, since it was missing a logger implementation in the classpath.

Also some minor cleanups.

Tested by creating a test project and running the code.

Co-authored-by: Lucas Brutschy <lucasbru@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants