Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: Revert "KAFKA-12960: Enforcing strict retention time for WindowStore and Sess…" #12745

Merged
merged 1 commit into from Oct 13, 2022

Conversation

cadonna
Copy link
Contributor

@cadonna cadonna commented Oct 13, 2022

This reverts commit 07c1002 which broke trunk.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

…owStore and Sess… (apache#11211)"

This reverts commit 07c1002 which broke trunk.
Copy link
Contributor

@dajac dajac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@showuon
Copy link
Contributor

showuon commented Oct 14, 2022

@cadonna , thanks for help revert the change. Although the jenkins tests passed in the PR, it could be because the code base is not synced up with the latest trunk.

@vamossagar12 , could you create another PR to include the original code change and also fix the failed tests? Thanks.

guozhangwang pushed a commit to guozhangwang/kafka that referenced this pull request Jan 25, 2023
…owStore and Sess… (apache#11211)" (apache#12745)

This reverts commit 07c1002 which broke trunk.

Reviewers: David Jacot <djacot@confluent.io>, Bill Bejeck <bbejeck@apache.org>
rutvijmehta-harness pushed a commit to rutvijmehta-harness/kafka that referenced this pull request Feb 9, 2024
…owStore and Sess… (apache#11211)" (apache#12745)

This reverts commit 07c1002 which broke trunk.

Reviewers: David Jacot <djacot@confluent.io>, Bill Bejeck <bbejeck@apache.org>
rutvijmehta-harness added a commit to rutvijmehta-harness/kafka that referenced this pull request Feb 9, 2024
…owStore and Sess… (apache#11211)" (apache#12745) (#57)

This reverts commit 07c1002 which broke trunk.

Reviewers: David Jacot <djacot@confluent.io>, Bill Bejeck <bbejeck@apache.org>

Co-authored-by: Bruno Cadonna <cadonna@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants