KAFKA-14247: add handler impl to the prototype #12775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirktrue
suggested changes
Oct 20, 2022
There was a problem hiding this comment.
Thanks @philipnee!
I assume the bulk of the additions here are copy-and-pasted from the existing KafkaConsumer?
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java
Show resolved
Hide resolved
…als/PrototypeAsyncConsumer.java Co-authored-by: Kirk True <kirk@kirktrue.pro>
vvcephei
requested changes
Oct 24, 2022
There was a problem hiding this comment.
Thanks for the PR, @philipnee !
I had a couple of small suggestions.
Do you think it's possible to also include a quick test to demonstrate that the code in this PR is effective?
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java
Outdated
Show resolved
Hide resolved
|
Added a test for the subscription() method. It's a bit complicated to test other method as the class is still Abstract. |
philipnee
commented
Oct 25, 2022
| @@ -64,27 +64,6 @@ public class DefaultBackgroundThread extends KafkaThread { | |||
| private final AtomicReference<Optional<RuntimeException>> exception = | |||
| new AtomicReference<>(Optional.empty()); | |||
|
|
|||
| public DefaultBackgroundThread(final ConsumerConfig config, | |||
There was a problem hiding this comment.
removing unused constructor for now.
vvcephei
approved these changes
Oct 25, 2022
|
I don't see how it could be related, but Gradle got a bunch of OOMEs on your last test run, so I kicked it off again. |
|
All right, thanks for that fix, @philipnee ! This time, the failures look unrelated: I'll go ahead and merge. |
guozhangwang
pushed a commit
to guozhangwang/kafka
that referenced
this pull request
Jan 25, 2023
Minor revision for KAFKA-14247. Added how the handler is called and constructed to the prototype code path. Reviewers: John Roesler <vvcephei@apache.org>, Kirk True <kirk@mustardgrain.com>
rutvijmehta-harness
pushed a commit
to rutvijmehta-harness/kafka
that referenced
this pull request
Feb 9, 2024
Minor revision for KAFKA-14247. Added how the handler is called and constructed to the prototype code path. Reviewers: John Roesler <vvcephei@apache.org>, Kirk True <kirk@mustardgrain.com>
rutvijmehta-harness
added a commit
to rutvijmehta-harness/kafka
that referenced
this pull request
Feb 9, 2024
Minor revision for KAFKA-14247. Added how the handler is called and constructed to the prototype code path. Reviewers: John Roesler <vvcephei@apache.org>, Kirk True <kirk@mustardgrain.com> Co-authored-by: Philip Nee <pnee@confluent.io>
rutvijmehta-harness
added a commit
to rutvijmehta-harness/kafka
that referenced
this pull request
Feb 10, 2024
Minor revision for KAFKA-14247. Added how the handler is called and constructed to the prototype code path. Reviewers: John Roesler <vvcephei@apache.org>, Kirk True <kirk@mustardgrain.com> Co-authored-by: Philip Nee <pnee@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*This is a minor revision for KAFKA-14247. We added how the handler is called and constructed to the prototype code path.
I also added the SubscriptionState instance to elucidate the idea that it is created on the client thread. The
subscription()demonstrates that it maintains the same access pattern as the current impl.Committer Checklist (excluded from commit message)