Replace EasyMock and PowerMock with Mockito - TimeOrderedWindowStoreTest #12777
Conversation
streams/src/test/java/org/apache/kafka/streams/state/internals/TimeOrderedWindowStoreTest.java
Outdated
Show resolved
Hide resolved
|
@divijvaidya Please have a look now. |
streams/src/test/java/org/apache/kafka/streams/state/internals/TimeOrderedWindowStoreTest.java
Outdated
Show resolved
Hide resolved
|
Hello @bbejeck! I have seen you collaborate with Divij Vaidya on a few pull requests and I was hoping you would lend us a hand in reviewing this pull request to get https://issues.apache.org/jira/browse/KAFKA-14133 over the line 😊 |
|
@cadonna is it possible get a review here as well? @shekhar-rajak, if there are any comments is it possible for you to address them? I will circle back in a week's time and if there are still outstanding comments I will takeover this pull request to get it to completion. |
|
Hi, This PR already have one approval and ready to merge. |
There was a problem hiding this comment.
Thanks for the PR and sorry for the delay. @cadonna is OOO this week and I will try help reviewing as much as I could.
This one looks good to me. Merging to trunk.
|
Great, thank you very much @guozhangwang! |
Related to KAFKA-14059 and KAFKA-14132
This is similar to the Open PR: #12739
Committer Checklist (excluded from commit message)