-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-14343: Upgrade tests for state updater #12801
Conversation
A test that verifies the upgrade from a version of Streams with state updater disabled to a version with state updater enabled and vice versa, so that we can offer a save upgrade path. - upgrade test from a version of Streams with state updater disabled to a version with state updater enabled - downgrade test from a version of Streams with state updater enabled to a version with state updater disabled
7e4bb2f
to
f0dfe6f
Compare
CI test failures are unrelated. Passing system test run 10x for the new upgrade / downgrade test: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5206/ @cadonna could you have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucasbru Thanks for the PR!
Here my feedback!
# rolling bounce | ||
random.shuffle(self.processors) | ||
for p in self.processors: | ||
p.CLEAN_NODE_ENABLED = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about cleaning the state on the node before we bounce so that some restoration is going on?
I think setting p.CLEAN_NODE_ENABLED
to True
would achieve this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea
Co-authored-by: Bruno Cadonna <cadonna@apache.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build failures are unrelated:
|
A test that verifies the upgrade from a version of Streams with state updater disabled to a version with state updater enabled and vice versa, so that we can offer a save upgrade path. - upgrade test from a version of Streams with state updater disabled to a version with state updater enabled - downgrade test from a version of Streams with state updater enabled to a version with state updater disabled Reviewer: Bruno Cadonna <cadonna@apache.org>
KAFKA-14343: Upgrade tests for state updater
A test that verifies the upgrade from a version of Streams with
state updater disabled to a version with state updater enabled
and vice versa, so that we can offer a save upgrade path.
disabled to a version with state updater enabled
enabled to a version with state updater disabled
Committer Checklist (excluded from commit message)