KAFKA-14367; Add SyncGroup to the new GroupCoordinator interface
#12847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolshan
reviewed
Nov 16, 2022
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala
Outdated
Show resolved
Hide resolved
jolshan
reviewed
Nov 16, 2022
| } | ||
|
|
||
| @Test | ||
| def testHandleSyncGroupRequestFutureFailed(): Unit = { |
There was a problem hiding this comment.
Confirming my understanding, we added testHandleSyncGroupRequestFutureFailed and testHandleSyncGroupRequestAuthenticationFailed?
jeffkbkim
reviewed
Nov 17, 2022
There was a problem hiding this comment.
i noticed that
org.apache.kafka.streams.integration.RestoreIntegrationTest
failed and the error message seems to indicate a rebalancing issue
java.lang.AssertionError: Expected all streams instances in [org.apache.kafka.streams.KafkaStreams@5e5d40ec] to be REBALANCING within 60000 ms, but the following were not: {org.apache.kafka.streams.KafkaStreams@5e5d40ec=RUNNING}
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorAdapterTest.scala
Show resolved
Hide resolved
dajac
force-pushed
the
KAFKA-14367-sync-group
branch
from
56605af
to
895d4b7
Compare
jolshan
approved these changes
Nov 30, 2022
jeffkbkim
approved these changes
Nov 30, 2022
dajac
commented
Nov 30, 2022
3 tasks
|
Sorry, was busy recently. I'll review it this week or next week. |
dajac
force-pushed
the
KAFKA-14367-sync-group
branch
from
5740665
to
65eeeb9
Compare
hachikuji
approved these changes
Dec 2, 2022
guozhangwang
pushed a commit
to guozhangwang/kafka
that referenced
this pull request
Jan 25, 2023
…pache#12847) This patch adds `syncGroup` to the new `GroupCoordinator` interface and updates `KafkaApis` to use it. Reviewers: Justine Olshan <jolshan@confluent.io>, Jeff Kim <jeff.kim@confluent.io>, Jason Gustafson <jason@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds
syncGroupto the newGroupCoordinatorinterface and updatesKafkaApisto use it.Committer Checklist (excluded from commit message)