Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-14367; Add DeleteGroups to the new GroupCoordinator interface #12858

Merged
merged 7 commits into from Dec 15, 2022

Conversation

dajac
Copy link
Contributor

@dajac dajac commented Nov 15, 2022

This patch adds deleteGroups to the new GroupCoordinator interface and updates KafkaApis to use it.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@dajac dajac added the KIP-848 label Nov 15, 2022
@dajac dajac changed the base branch from KAFKA-14367-join-group to trunk November 30, 2022 12:41
Copy link
Contributor

@jolshan jolshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- once we add the helper method

Copy link
Contributor

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dajac dajac merged commit f8556fe into apache:trunk Dec 15, 2022
@dajac dajac deleted the KAFKA-14367-delete-groups branch December 15, 2022 08:30
guozhangwang pushed a commit to guozhangwang/kafka that referenced this pull request Jan 25, 2023
…ce (apache#12858)

This patch adds `deleteGroups` to the new `GroupCoordinator` interface and updates `KafkaApis` to use it.

Reviewers: Omnia G H Ibrahim <o.g.h.ibrahim@gmail.com>, Justine Olshan <jolshan@confluent.io>, Jason Gustafson <jason@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants