-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-14474: Move OffsetIndex to storage module #13009
KAFKA-14474: Move OffsetIndex to storage module #13009
Conversation
8c169ab
to
bfc38de
Compare
bfc38de
to
b68f9c6
Compare
For broader context on this change, please check: KAFKA-14470: Move log layer to storage module
b68f9c6
to
3fd84ef
Compare
Test failures look unrelated, re-running just in case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ijuma : Thanks for the PR, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ijuma : Thanks for the PR. LGTM. Just a minor comment.
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@junrao I think most editors expect a new line at the end. For example, IntelliJ adds it automatically after I delete the new line and save the file (I tried it just now). And vim doesn't even show that there is a new line. So, I think we should probably leave it in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation. Sounds good.
Failures are unrelated. |
For broader context on this change, please check: * KAFKA-14470: Move log layer to storage module Reviewers: Jun Rao <junrao@gmail.com>, Satish Duggana <satishd@apache.org>
For broader context on this change, please check:
Committer Checklist (excluded from commit message)