KAFKA-14550: Move SnapshotFile and CorruptSnapshotException to storage module #13039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satishd
changed the title
satishd
force-pushed
the
KAFKA-14480-pre-producer-statemanager-move
branch
from
67f14e9
to
314cfec
Compare
satishd
changed the title
satishd
changed the title
satishd
changed the title
satishd
changed the title
|
@satishd Can you please fix the conflicts? |
satishd
force-pushed
the
KAFKA-14480-pre-producer-statemanager-move
branch
2 times, most recently
from
6006703
to
ffe2c0a
Compare
satishd
force-pushed
the
KAFKA-14480-pre-producer-statemanager-move
branch
from
ffe2c0a
to
187d7f7
Compare
|
@ijuma These changes are updated with the latest trunk and resolved the conflicts. |
3 tasks
ijuma
reviewed
Dec 30, 2022
storage/src/main/java/org/apache/kafka/server/log/internals/SnapshotFile.java
Outdated
Show resolved
Hide resolved
storage/src/main/java/org/apache/kafka/server/log/internals/SnapshotFile.java
Show resolved
Hide resolved
|
@satishd did you see my review above? |
Addressed review comments.
…ced offsetFromFileName in UnifiedLog/LocalLog.
|
@ijuma Sorry, Brave browser(+plugins) had some issues in refreshing the github PR page and missed your update. |
ijuma
changed the title
|
The build for all 3 JDK versions passed. |
guozhangwang
pushed a commit
to guozhangwang/kafka
that referenced
this pull request
Jan 25, 2023
…e module (apache#13039) For broader context on this change, see: * KAFKA-14470: Move log layer to storage module Reviewers: Ismael Juma <ismael@juma.me.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KAFKA-14550 Move SnapshotFile and CorruptSnapshotException to storage module.
For broader context on this change, you may want to look at KAFKA-14470: Move log layer to storage module
Committer Checklist (excluded from commit message)