KAFKA-14463 Invoke of ConnectorClientConfigOverridePolicy#close #13144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0urante
reviewed
Jan 23, 2023
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java
Outdated
Show resolved
Hide resolved
...a/org/apache/kafka/connect/connector/policy/BaseConnectorClientConfigOverridePolicyTest.java
Show resolved
Hide resolved
...untime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java
Outdated
Show resolved
Hide resolved
…/AbstractHerder.java Co-authored-by: Chris Egerton <fearthecellos@gmail.com>
|
@C0urante Thanks for the review. I've applied your suggestions. Please, take a look one more time. |
guozhangwang
pushed a commit
to guozhangwang/kafka
that referenced
this pull request
Jan 25, 2023
…he#13144) Reviewers: Chris Egerton <chrise@aiven.io>
C0urante
pushed a commit
to aiven/kafka
that referenced
this pull request
Mar 27, 2023
…he#13144) Reviewers: Chris Egerton <chrise@aiven.io>
giuseppelillo
pushed a commit
to aiven/kafka
that referenced
this pull request
Mar 29, 2023
…he#13144) Reviewers: Chris Egerton <chrise@aiven.io>
giuseppelillo
pushed a commit
to aiven/kafka
that referenced
this pull request
Apr 6, 2023
…he#13144) Reviewers: Chris Egerton <chrise@aiven.io>
eliax1996
pushed a commit
to aiven/kafka
that referenced
this pull request
Jul 3, 2023
…he#13144) Reviewers: Chris Egerton <chrise@aiven.io>
jeqo
pushed a commit
to aiven/kafka
that referenced
this pull request
Sep 28, 2023
…he#13144) Reviewers: Chris Egerton <chrise@aiven.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConnectorClientConfigOverridePolicyimplementsAutoCloseablebut close method not called.Committer Checklist (excluded from commit message)