[DO NOT MERGE] KAFKA-14533: re-enable the 'false' parameter of SmokeTestDriverIntegrationTest #13155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ableegoldman
commented
Jan 23, 2023
| // TODO KAFKA-14533: debug and re-enable both parameters | ||
| Boolean.TRUE | ||
| //Boolean.FALSE | ||
| Boolean.FALSE, |
There was a problem hiding this comment.
For some additional data I also swapped the order of the two parameters, in case that happens to reveal something about the underlying source of failure here 🤷♀️
mjsax
approved these changes
Jan 24, 2023
ableegoldman
pushed a commit
that referenced
this pull request
Jan 24, 2023
…okeTestDriverIntegrationTest (#13156) I immediately saw a failure with stateUpdaterEnabled = true after disabling the false parameter, which suggests the problem actually does lie in the state updater itself and not the act of parametrization of the test. To verify this theory, and help stabilize the 3.4 release branch, let's try one more test by swapping out the true build in favor of the false one. If the listOffsets requests stop failing and causing this integration test to hit the global timeout as is currently happening at such a high rate, then we have pretty good evidence pointing at the state updater and should be able to debug things more easily from there. After getting in a few builds to see whether the flakiness subsides, we should merge this PR to re-enable both parameters going forward: #13155 Reviewers: Anna Sophie Blee-Goldman <ableegoldman@apache.org>
ableegoldman
pushed a commit
that referenced
this pull request
Jan 24, 2023
…okeTestDriverIntegrationTest (#13156) I immediately saw a failure with stateUpdaterEnabled = true after disabling the false parameter, which suggests the problem actually does lie in the state updater itself and not the act of parametrization of the test. To verify this theory, and help stabilize the 3.4 release branch, let's try one more test by swapping out the true build in favor of the false one. If the listOffsets requests stop failing and causing this integration test to hit the global timeout as is currently happening at such a high rate, then we have pretty good evidence pointing at the state updater and should be able to debug things more easily from there. After getting in a few builds to see whether the flakiness subsides, we should merge this PR to re-enable both parameters going forward: #13155 Reviewers: Anna Sophie Blee-Goldman <ableegoldman@apache.org>
ableegoldman
force-pushed
the
MINOR-reenable-SmokeTestDriverIntegrationTest-on-trunk
branch
from
1b8a6b2
to
f5a8dd6
Compare
guozhangwang
pushed a commit
to guozhangwang/kafka
that referenced
this pull request
Jan 25, 2023
…okeTestDriverIntegrationTest (apache#13156) I immediately saw a failure with stateUpdaterEnabled = true after disabling the false parameter, which suggests the problem actually does lie in the state updater itself and not the act of parametrization of the test. To verify this theory, and help stabilize the 3.4 release branch, let's try one more test by swapping out the true build in favor of the false one. If the listOffsets requests stop failing and causing this integration test to hit the global timeout as is currently happening at such a high rate, then we have pretty good evidence pointing at the state updater and should be able to debug things more easily from there. After getting in a few builds to see whether the flakiness subsides, we should merge this PR to re-enable both parameters going forward: apache#13155 Reviewers: Anna Sophie Blee-Goldman <ableegoldman@apache.org>
|
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) |
|
re-enabled already in beb0be5#diff-26010bb30ef947a13d4d6d35866c892258dc59dad4d5e2d40c9bb6059fb35381R99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing the PR to re-enable the test build that I temporarily disabled in #13147 in order to help with debugging and to stabilize the 3.4 release branch.
I'm still debugging this so we should not merge this PR just yet, but I wanted to at least open it now so it's not forgotten