KAFKA-14491: [4/N] Improvements to segment value format for RocksDB versioned store #13186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
vcrfxia
commented
Feb 2, 2023
| * the relevant index (to insert into index n requires that index n-1 has already been deserialized). | ||
| * Inserts the provided record into the segment row at the provided index. This operation | ||
| * requires that {@link SegmentValue#find(long, boolean)} has already been called in order to deserialize | ||
| * the relevant index (to insert into index n requires that index n has already been deserialized). |
There was a problem hiding this comment.
The requirement change from n-1 to n is because using n-1 means callers could attempt to call this method on a degenerate segment, which would not be valid. In practice, callers never have reason to call this method with n-1; only the internal implementation of insertAsLatest() has reason to do this, but this method calls the helper method doInsert() directly instead.
By updating this requirement from n-1 to n, it ensures that callers will never be allowed to call this method on a degenerate segment, and that note can be removed from the javadocs as a result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to the segment value format introduced in #13126, as a follow-up to the latest PR review.
Committer Checklist (excluded from commit message)