-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-14578: Move ConsumerPerformance to tools #13215
Conversation
fvaleri
commented
Feb 7, 2023
•
edited
edited
0bdd2e1
to
5f5026d
Compare
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java
Outdated
Show resolved
Hide resolved
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java
Outdated
Show resolved
Hide resolved
=== test data bin/kafka-producer-perf-test.sh --num-records 30000 --record-size 1000 --throughput 200 --topic my-topic --producer-props bootstrap.servers=:9092 linger.ms=0 batch.size=16384 ... 30000 records sent, 199.973337 records/sec (0.19 MB/sec), 1.26 ms avg latency, 205.00 ms max latency, 1 ms 50th, 2 ms 95th, 2 ms 99th, 14 ms 99.9th. === test 1 bin/kafka-consumer-perf-test.sh --bootstrap-server :9092 --messages 3000 --timeout 10000 --fetch-size 1048576 --topic my-topic --group my-group start.time, end.time, data.consumed.in.MB, MB.sec, data.consumed.in.nMsg, nMsg.sec, rebalance.time.ms, fetch.time.ms, fetch.MB.sec, fetch.nMsg.sec 2023-02-07 17:53:25:127, 2023-02-07 17:53:28:418, 3.2864, 0.9986, 3446, 1047.0981, 3222, 69, 47.6284, 49942.0290 start.time, end.time, data.consumed.in.MB, MB.sec, data.consumed.in.nMsg, nMsg.sec, rebalance.time.ms, fetch.time.ms, fetch.MB.sec, fetch.nMsg.sec 2023-02-07 17:54:23:268, 2023-02-07 17:54:26:579, 3.2806, 0.9908, 3440, 1038.9610, 96, 3215, 1.0204, 1069.9844 === test 2 bin/kafka-consumer-perf-test.sh --bootstrap-server :9092 --messages 3000 --timeout 10000 --fetch-size 100 --topic my-topic --group my-group --show-detailed-stats --reporting-interval 100 === old 2023-02-07 17:58:09:633, 0, 0.0010, 0.0003, 1, 0.3089, 3212, 25, 0.0381, 40.0000 2023-02-07 17:58:09:733, 0, 0.2279, 2.2697, 239, 2380.0000, 0, 100, 2.2697, 2380.0000 2023-02-07 17:58:09:833, 0, 0.5789, 3.5095, 607, 3680.0000, 0, 100, 3.5095, 3680.0000 2023-02-07 17:58:09:933, 0, 1.0824, 5.0354, 1135, 5280.0000, 0, 100, 5.0354, 5280.0000 2023-02-07 17:58:10:033, 0, 1.8015, 7.1907, 1889, 7540.0000, 0, 100, 7.1907, 7540.0000 2023-02-07 17:58:10:133, 0, 2.8172, 10.1566, 2954, 10650.0000, 0, 100, 10.1566, 10650.0000 === new 2023-02-07 17:58:39:549, 0, 0.0010, 0.0003, 1, 0.0000, 0, 3244, 0.0003, 0.3083 2023-02-07 17:58:39:649, 0, 0.2327, 2.3174, 244, 2000.0000, 0, 100, 2.3174, 2430.0000 2023-02-07 17:58:39:749, 0, 0.5293, 2.9659, 555, 3000.0000, 0, 100, 2.9659, 3110.0000 2023-02-07 17:58:39:849, 0, 0.8564, 3.2711, 898, 3000.0000, 0, 100, 3.2711, 3430.0000 2023-02-07 17:58:39:949, 0, 1.2941, 4.3774, 1357, 4000.0000, 0, 100, 4.3774, 4590.0000 2023-02-07 17:58:40:049, 0, 2.0247, 7.3051, 2123, 7000.0000, 0, 100, 7.3051, 7660.0000 === test 3 bin/kafka-consumer-perf-test.sh --bootstrap-server :9092 --messages 3000 --timeout 10000 --fetch-size 100 --topic my-topic --group my-group & bin/kafka-consumer-perf-test.sh --bootstrap-server :9092 --messages 3000 --timeout 10000 --fetch-size 100 --topic my-topic --group my-group & wait === old 2023-02-07 18:10:21:826, 2023-02-07 18:10:25:780, 2.8610, 0.7236, 3000, 758.7253, 3238, 716, 3.9958, 4189.9441 2023-02-07 18:10:21:824, 2023-02-07 18:10:25:988, 2.8610, 0.6871, 3000, 720.4611, 3239, 925, 3.0930, 3243.2432 === new 2023-02-07 18:11:10:173, 2023-02-07 18:11:14:111, 2.8610, 0.7265, 3000, 761.8080, 671, 3267, 0.8757, 918.2736 2023-02-07 18:11:10:238, 2023-02-07 18:11:14:294, 2.8610, 0.7054, 3000, 739.6450, 852, 3204, 0.8930, 936.3296 === system test TC_PATHS="tests/kafkatest/benchmarks/core/benchmark_test.py::Benchmark.test_producer_and_consumer" bash tests/docker/run_tests.sh === old SESSION REPORT (ALL TESTS) ducktape version: 0.11.3 session_id: 2023-02-07--006 run time: 7 minutes 12.212 seconds tests run: 6 passed: 6 flaky: 0 failed: 0 ignored: 0 === new SESSION REPORT (ALL TESTS) ducktape version: 0.11.3 session_id: 2023-02-07--007 run time: 7 minutes 21.450 seconds tests run: 6 passed: 6 flaky: 0 failed: 0 ignored: 0 Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
5f5026d
to
e43d9a8
Compare
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I left a few comments.
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java
Outdated
Show resolved
Hide resolved
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java
Outdated
Show resolved
Hide resolved
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
@mimaison thanks for the review. I fixed the rebalance listener and re-ran all the tests in the description. |
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java
Outdated
Show resolved
Hide resolved
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Federico Valeri <fedevaleri@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM