KAFKA-14706 Move/rewrite ShutdownableThread to server-common module. #13234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijuma
reviewed
Feb 12, 2023
ijuma
reviewed
Feb 12, 2023
server-common/src/main/java/org/apache/kafka/server/util/ShutdownableThread.java
Outdated
Show resolved
Hide resolved
satishd
force-pushed
the
KAFKA-14706
branch
2 times, most recently
from
21d43b5
to
a020dcd
Compare
|
Test failure does not seem to be related to the changes in the PR. |
|
I won't have a chance to review for a few more days - if @showuon can do it sooner, let's not block on me. |
|
I'll take a look today. |
|
One failing test is not related to this change, ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KAFKA-14706 Move/rewrite ShutdownableThread to
server-commonmodule.Committer Checklist (excluded from commit message)