KAFKA-14491: [10/N] Add changelogging wrapper for versioned stores #13251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 15, 2023
vcrfxia
force-pushed
the
kip-889-changelogging-store
branch
from
408c364
to
2b8997a
Compare
mjsax
approved these changes
Feb 17, 2023
| ChangeLoggingVersionedKeyValueBytesStore(final KeyValueStore<Bytes, byte[]> inner) { | ||
| super(inner); | ||
| if (!(inner instanceof VersionedBytesStore)) { | ||
| throw new IllegalStateException("inner store must be versioned"); |
| public void shouldPropagateAndLogOnPutNull() { | ||
| final Bytes rawKey = Bytes.wrap(rawBytes("k")); | ||
| final long timestamp = 10L; | ||
| final byte[] rawValueAndTimestamp = rawValueAndTimestamp(null, timestamp); |
vcrfxia
force-pushed
the
kip-889-changelogging-store
branch
from
de883ad
to
635394b
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the changelogging layer for the new versioned key-value store introduced in KIP-889. We choose to have the changelogging layer operate on
VersionedBytesStorerather thanVersionedKeyValueStoreso that the outermost store layer (metered store, see #13252 for more) can serialize to bytes once and then all inner stores operate only with bytes types.Changelog topic configs for versioned stores need to be slightly different than for non-versioned key-value stores. This change will be made in a follow-up PR.
Committer Checklist (excluded from commit message)