Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-14447: remove stale TODO comment #13258

Merged
merged 1 commit into from Mar 10, 2023
Merged

Conversation

showuon
Copy link
Contributor

@showuon showuon commented Feb 16, 2023

Checked the code, and confirmed the controlled shutdown for ZK brokers during migration can either send to ZK controller, or send to KRaft controller via lifecycle manager based on the controller is ZK controller or KRaft controller. Removed the stale TO comments and complete this task.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@showuon
Copy link
Contributor Author

showuon commented Feb 16, 2023

@mumrah @akhileshchg , call for review. Thanks.

Copy link
Contributor

@mumrah mumrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @showuon

@mumrah mumrah merged commit 20e0569 into apache:trunk Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants